Migrate off @azure/ms-rest-js#2560
Merged
MikhailSuendukov merged 4 commits intomasterfrom Jan 22, 2025
Merged
Conversation
MikhailSuendukov
requested review from
DmitriyKirakosyan,
DordeDimitrijev and
IlyaBausovAkvelon
Contributor
|
Can you please attach build inside description? |
…/remove-ms-rest-js-related-unused-code
IlyaBausovAkvelon
suggested changes
Jan 15, 2025
Contributor
IlyaBausovAkvelon
left a comment
IlyaBausovAkvelon
left a comment
There was a problem hiding this comment.
Only ClientRequest Interface is needed from create-client.ts. I've made branch fix/remove-ms-rest-js-related-unused-code with these changes.
Contributor
|
I've also checked it out and I suppose we can merge the changes from fix/remove-ms-rest-js-related-unused-code into this PR and update the description? |
IlyaBausovAkvelon
previously approved these changes
Jan 20, 2025
MikhailSuendukov
dismissed
IlyaBausovAkvelon’s stale review
The merge-base changed after approval.
DmitriyKirakosyan
previously approved these changes
Jan 20, 2025
MikhailSuendukov
dismissed
DmitriyKirakosyan’s stale review
The merge-base changed after approval.
IlyaBausovAkvelon
previously approved these changes
Jan 21, 2025
MikhailSuendukov
dismissed
IlyaBausovAkvelon’s stale review
The merge-base changed after approval.
DordeDimitrijev
previously approved these changes
Jan 21, 2025
MikhailSuendukov
dismissed
DordeDimitrijev’s stale review
The merge-base changed after approval.
DmitriyKirakosyan
previously approved these changes
Jan 22, 2025
MikhailSuendukov
dismissed
DmitriyKirakosyan’s stale review
The merge-base changed after approval.
DmitriyKirakosyan
previously approved these changes
Jan 22, 2025
MikhailSuendukov
dismissed
DmitriyKirakosyan’s stale review
The merge-base changed after approval.
IlyaBausovAkvelon
previously approved these changes
Jan 22, 2025
MikhailSuendukov
dismissed
IlyaBausovAkvelon’s stale review
The merge-base changed after approval.
lucen-ms
previously approved these changes
Jan 22, 2025
MikhailSuendukov
dismissed
lucen-ms’s stale review
The merge-base changed after approval.
DmitriyKirakosyan
approved these changes
Jan 22, 2025
lucen-ms
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The package @azure/ms-rest-js is no longer being actively maintained. So, moving to @azure/core-rest-pipeline and @azure/core-client packages.
Build succeed.
Links
#2549
AB#109355