Fix Autolinking for React Native 0.69#980
Closed
Naturalclar wants to merge 1 commit intomicrosoft:developfrom
Closed
Fix Autolinking for React Native 0.69#980Naturalclar wants to merge 1 commit intomicrosoft:developfrom
Naturalclar wants to merge 1 commit intomicrosoft:developfrom
Conversation
MatkovIvan
reviewed
Jun 24, 2022
Contributor
MatkovIvan
left a comment
MatkovIvan
left a comment
There was a problem hiding this comment.
I'm not sure that it will work with previous versions, so it's just TODO for reviewers: we must test it not only with 0.69
Zestpond
approved these changes
Jun 27, 2022
|
Any good news to update on this issue ? |
Contributor
|
Hi @sunchanras , I'm currently testing it with different RN version. I confirm it works with RN 0.69 and it also looks working for pervious versions. I will merge it as soon as I'm sure it doesn't break anything. |
|
@DmitriyKirakosyan Nice. Thank you. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things to consider before you submit the PR:
CHANGELOG.mdbeen updated?Description
Moved podspec location to root directory of project as it is required for autolinking to work in react-native/cli v8
Also removed podspecPath from react-native.config as the parameter is deprecated, making autolink to fail
react-native-community/cli#1537
A few sentences describing the overall goals of the pull request.
Related PRs or issues
List related PRs and other issues.
#979
Misc
Add what's missing, notes on what you tested, additional thoughts or questions.