Update example of how to disable device collection#53
Update example of how to disable device collection#53daytonellwanger wants to merge 1 commit intomicrosoft:mainfrom
Conversation
| var appInsights = new ApplicationInsights({ | ||
| config: { | ||
| instrumentationKey: 'YOUR_INSTRUMENTATION_KEY_GOES_HERE', | ||
| disableDeviceCollection: true, |
There was a problem hiding this comment.
Actually, looking at the current code this is a configuration is only used from the passed in configuration... The config that is passed to the constructor is actually never used.....
Which version are you using (older versions may have referenced it).
Based on what I just reviewed of the classes the correct approach is actually
- Remove the "config" from the constructor as it's not used (unless it's referenced in another class -- I just looked at the manual one)
- The config location "works" as currently defined, but would be more correctly located in the
extensionConfig["AppInsightsReactNativePlugin"]: { disabeDeviceCollection: true; }which is where you will see it after initialization (and also where you can dynamically change it's value with the current version -- as we now expose all of the configurable values by exposing the internal defaults in their "true" location.
The reason it "works" (or at least it should be) being defined in the root (rather than in the extensionConfig) is historical and as long as the extension config is not also defined (by you) we still "support" reading and config specific value from the root of the config object.
MSNev
left a comment
There was a problem hiding this comment.
See comment, I don't believe that this change "works" with the current version @siyuniu-ms I'll let you validate and please give me feedback if what I've said is incorrect.
|
Reassigning to Karlie |
disableDeviceCollectionis a property onReactNativePluginconfiguration, notApplicationInsightsconfiguration.