Skip to content

Conversation

@MSNev
Copy link
Contributor

@MSNev MSNev commented May 12, 2025

  • remove grunt-contrib-qunit
  • update puppeteer

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates components to address Component Governance issues by removing the grunt-contrib-qunit dependency across various package files and updating the puppeteer version.

  • Removed grunt-contrib-qunit (and related dependencies like tar-fs) from several package.json files and the gruntfile
  • Updated puppeteer to version 24.8.2 and added eventemitter2 as a dependency
  • Added tools/grunt-tasks/chrome/bridge.js, which appears to vendor some grunt-contrib-qunit related functionality

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/rollup-plugin-uglify3-js/package.json Removed grunt-contrib-qunit and tar-fs from devDependencies
tools/grunt-tasks/chrome/bridge.js Added new file that implements QUnit message bridging, but still references grunt-contrib-qunit
package.json Removed grunt-contrib-qunit and tar-fs; updated puppeteer version and added eventemitter2
gruntfile.js Removed loading of grunt-contrib-qunit task
common/Tests/Framework/package.json Removed grunt-contrib-qunit and tar-fs from devDependencies
applicationinsights-react-native/package.json Removed grunt-contrib-qunit and tar-fs from devDependencies

- remove grunt-contrib-qunit
- update puppeteer
@MSNev MSNev force-pushed the MSNev/UpdateComponents branch from 9977b2a to 1cec33e Compare May 12, 2025 23:52
@MSNev MSNev merged commit 5ab8906 into main May 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants