Add ability for ContainerResource to reach ProjectResource by name in Run mode#327
Open
dombrovsky wants to merge 1 commit intomicrosoft:mainfrom
Open
Add ability for ContainerResource to reach ProjectResource by name in Run mode#327dombrovsky wants to merge 1 commit intomicrosoft:mainfrom
dombrovsky wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
|
I don't think we should make the metrics example more complex. |
Contributor
|
This container proxy resource is a very cool stand alone sample though. |
Author
|
Thanks for review. I'll prepare it as a standalone sample and update PR. |
…ginx container as a proxy between containers and ProjectResources available on host.docker.internal
421aaa8 to
044afc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies Metrics sample.
The goal is to change in
prometheus.ymlthis- targets: ['host.docker.internal:5048'] # hard-coded port matches launchSettings.jsonto this
- targets: ['app'],so that prometheus container can reach metricsapp that runs on host in development environment by resource name instead of hardcoded endpoint.
In this PR this is achieved by: