Skip to content

Add missing namespace#386

Merged
IEvangelist merged 1 commit intomicrosoft:mainfrom
afscrome:patch-1
Feb 9, 2026
Merged

Add missing namespace#386
IEvangelist merged 1 commit intomicrosoft:mainfrom
afscrome:patch-1

Conversation

@afscrome
Copy link
Contributor

@afscrome afscrome commented Feb 7, 2026

IDistributedApplicationEventingSubscriber is in Aspire.Hosting.Lifecycle

`IDistributedApplicationEventingSubscriber` is in `using Aspire.Hosting.Lifecycle`
@afscrome afscrome requested a review from IEvangelist as a code owner February 7, 2026 21:18
Copilot AI review requested due to automatic review settings February 7, 2026 21:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the AppHost eventing documentation to include the correct namespace import for IDistributedApplicationEventingSubscriber, so the sample compiles as written.

Changes:

  • Add using Aspire.Hosting.Lifecycle; to the Eventing subscribers example in the docs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IEvangelist IEvangelist enabled auto-merge (squash) February 9, 2026 13:33
@IEvangelist IEvangelist merged commit c593e67 into microsoft:main Feb 9, 2026
11 of 12 checks passed
maddymontaquila pushed a commit that referenced this pull request Feb 12, 2026
`IDistributedApplicationEventingSubscriber` is in `using Aspire.Hosting.Lifecycle`
IEvangelist added a commit that referenced this pull request Feb 17, 2026
* Documenting DCPCliPath (#380)

* Add missing namespace (#386)

`IDistributedApplicationEventingSubscriber` is in `using Aspire.Hosting.Lifecycle`

* Update devtunnel CLI installation link to correct URL (#382)

* Update devtunnel CLI installation link to correct URL

* Apply suggestion from @IEvangelist

---------

Co-authored-by: David Pine <david.pine@microsoft.com>

* Explain how to start & stop resources manually (#381)

* Replace Hex1b MCP server with Hex1b.Tool CLI (#387)

* Replace Hex1b MCP server with Hex1b.Tool CLI

- Remove hex1b MCP server configs from .mcp.json, .vscode/mcp.json, opencode.jsonc
- Add hex1b skill file generated by 'hex1b agent init'
- Update doc-writer skill to reference hex1b CLI commands
- Update doc-tester skill to reference hex1b CLI commands

* Address PR feedback: fix install command, recording example, and key names

- Fix install command to specify --global or --local scope
- Add --output to recording start example in doc-tester
- Fix ArrowUp → UpArrow to match Hex1bKey enum
- Expand key name list to include all Hex1bKey enum values

---------

Co-authored-by: Mitch Denny <mitch@mitchdeny.com>

* Add agentic control plane card and rearrange homepage layout

---------

Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com>
Co-authored-by: Alex Crome <afscrome@users.noreply.github.com>
Co-authored-by: Alex Ravenna <alex.n.ravenna@gmail.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Bottiau <bottiau.david@laposte.net>
Co-authored-by: Mitch Denny <midenn@microsoft.com>
Co-authored-by: Mitch Denny <mitch@mitchdeny.com>
IEvangelist added a commit that referenced this pull request Feb 17, 2026
* Documenting DCPCliPath (#380)

* Add missing namespace (#386)

`IDistributedApplicationEventingSubscriber` is in `using Aspire.Hosting.Lifecycle`

* Update devtunnel CLI installation link to correct URL (#382)

* Update devtunnel CLI installation link to correct URL

* Apply suggestion from @IEvangelist

---------

Co-authored-by: David Pine <david.pine@microsoft.com>

* Explain how to start & stop resources manually (#381)

* Replace Hex1b MCP server with Hex1b.Tool CLI (#387)

* Replace Hex1b MCP server with Hex1b.Tool CLI

- Remove hex1b MCP server configs from .mcp.json, .vscode/mcp.json, opencode.jsonc
- Add hex1b skill file generated by 'hex1b agent init'
- Update doc-writer skill to reference hex1b CLI commands
- Update doc-tester skill to reference hex1b CLI commands

* Address PR feedback: fix install command, recording example, and key names

- Fix install command to specify --global or --local scope
- Add --output to recording start example in doc-tester
- Fix ArrowUp → UpArrow to match Hex1bKey enum
- Expand key name list to include all Hex1bKey enum values

---------

Co-authored-by: Mitch Denny <mitch@mitchdeny.com>

* Add agentic control plane card and rearrange homepage layout

---------

Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com>
Co-authored-by: Alex Crome <afscrome@users.noreply.github.com>
Co-authored-by: Alex Ravenna <alex.n.ravenna@gmail.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Bottiau <bottiau.david@laposte.net>
Co-authored-by: Mitch Denny <midenn@microsoft.com>
Co-authored-by: Mitch Denny <mitch@mitchdeny.com>
IEvangelist added a commit that referenced this pull request Feb 18, 2026
* Documenting DCPCliPath (#380)

* Add missing namespace (#386)

`IDistributedApplicationEventingSubscriber` is in `using Aspire.Hosting.Lifecycle`

* Update devtunnel CLI installation link to correct URL (#382)

* Update devtunnel CLI installation link to correct URL

* Apply suggestion from @IEvangelist

---------

Co-authored-by: David Pine <david.pine@microsoft.com>

* Explain how to start & stop resources manually (#381)

* Replace Hex1b MCP server with Hex1b.Tool CLI (#387)

* Replace Hex1b MCP server with Hex1b.Tool CLI

- Remove hex1b MCP server configs from .mcp.json, .vscode/mcp.json, opencode.jsonc
- Add hex1b skill file generated by 'hex1b agent init'
- Update doc-writer skill to reference hex1b CLI commands
- Update doc-tester skill to reference hex1b CLI commands

* Address PR feedback: fix install command, recording example, and key names

- Fix install command to specify --global or --local scope
- Add --output to recording start example in doc-tester
- Fix ArrowUp → UpArrow to match Hex1bKey enum
- Expand key name list to include all Hex1bKey enum values

---------

Co-authored-by: Mitch Denny <mitch@mitchdeny.com>

* Add agentic control plane card and rearrange homepage layout

---------

Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com>
Co-authored-by: Alex Crome <afscrome@users.noreply.github.com>
Co-authored-by: Alex Ravenna <alex.n.ravenna@gmail.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Bottiau <bottiau.david@laposte.net>
Co-authored-by: Mitch Denny <midenn@microsoft.com>
Co-authored-by: Mitch Denny <mitch@mitchdeny.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants