Skip to content

Update write-your-first-test.mdx#438

Open
mrhaugan wants to merge 2 commits intomicrosoft:mainfrom
mrhaugan:patch-1
Open

Update write-your-first-test.mdx#438
mrhaugan wants to merge 2 commits intomicrosoft:mainfrom
mrhaugan:patch-1

Conversation

@mrhaugan
Copy link
Contributor

  • 'ResourceExtensions.GetEnvironmentVariableValuesAsync(IResourceWithEnvironment, DistributedApplicationOperation)' is obsolete: 'Use ExecutionConfigurationBuilder instead.'

  • Got help from CoPilot: "Use ExecutionConfigurationBuilder directly."

  • Passing test

- 'ResourceExtensions.GetEnvironmentVariableValuesAsync(IResourceWithEnvironment, DistributedApplicationOperation)' is obsolete: 'Use ExecutionConfigurationBuilder instead.'

- Got help from CoPilot: "Use ExecutionConfigurationBuilder directly."

- Passing test
@mrhaugan
Copy link
Contributor Author

Dang, forgot to update the text below that summarizes the test code

- Updating the summarizing text
- Add code change to other testing framework examples
@mrhaugan
Copy link
Contributor Author

@mrhaugan please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

DistributedApplicationOperation.Publish);
var executionConfiguration = await ExecutionConfigurationBuilder.Create(frontend.Resource)
.WithEnvironmentVariablesConfig()
.BuildAsync(new(DistributedApplicationOperation.Publish), Microsoft.Extensions.Logging.Abstractions.NullLogger.Instance, CancellationToken.None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.BuildAsync(new(DistributedApplicationOperation.Publish), Microsoft.Extensions.Logging.Abstractions.NullLogger.Instance, CancellationToken.None)
.BuildAsync(new(DistributedApplicationOperation.Publish), NullLogger.Instance, CancellationToken.None)

DistributedApplicationOperation.Publish);
var executionConfiguration = await ExecutionConfigurationBuilder.Create(frontend.Resource)
.WithEnvironmentVariablesConfig()
.BuildAsync(new(DistributedApplicationOperation.Publish), Microsoft.Extensions.Logging.Abstractions.NullLogger.Instance, CancellationToken.None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.BuildAsync(new(DistributedApplicationOperation.Publish), Microsoft.Extensions.Logging.Abstractions.NullLogger.Instance, CancellationToken.None)
.BuildAsync(new(DistributedApplicationOperation.Publish), NullLogger.Instance, CancellationToken.None)

DistributedApplicationOperation.Publish);
var executionConfiguration = await ExecutionConfigurationBuilder.Create(frontend.Resource)
.WithEnvironmentVariablesConfig()
.BuildAsync(new(DistributedApplicationOperation.Publish), Microsoft.Extensions.Logging.Abstractions.NullLogger.Instance, CancellationToken.None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having removed the fully qualified naming, we might need a using Microsoft.Extensions.Logging.Abstractions; at the top.

Suggested change
.BuildAsync(new(DistributedApplicationOperation.Publish), Microsoft.Extensions.Logging.Abstractions.NullLogger.Instance, CancellationToken.None)
.BuildAsync(new(DistributedApplicationOperation.Publish), NullLogger.Instance, CancellationToken.None)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants