[release/13.0] Add test cases and ensure container cert override paths work#12657
Merged
joperezr merged 3 commits intorelease/13.0from Nov 6, 2025
Merged
[release/13.0] Add test cases and ensure container cert override paths work#12657joperezr merged 3 commits intorelease/13.0from
joperezr merged 3 commits intorelease/13.0from
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12657Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12657" |
davidfowl
reviewed
Nov 4, 2025
| [InlineData(true, false, false)] | ||
| [InlineData(true, true, true)] | ||
| public async Task VerifyContainerIncludesExpectedDevCertificateConfiguration(bool? implicitTrust, bool? explicitTrust, bool expectDevCert) | ||
| [InlineData(null, null, true, false, CertificateTrustScope.Append)] |
Contributor
There was a problem hiding this comment.
I hope you generated this. I would have used property data and a helper routine to generate all combinations.
Member
There was a problem hiding this comment.
This was very much some copilot generated test combos.
karolz-ms
approved these changes
Nov 4, 2025
davidfowl
reviewed
Nov 4, 2025
Comment on lines
+2488
to
+2490
| var filename = Path.GetFileName(bp); | ||
| var dir = bp.Substring(0, bp.Length - filename.Length); | ||
| return (dir, filename); |
Contributor
There was a problem hiding this comment.
Do we need to be more defensive here?
Member
There was a problem hiding this comment.
Only reason this would result in invalid directory or filename is if the user customized the paths and then it would be DCP that would actually return an error due to invalid create file arguments (missing filename or invalid path).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12654 to release/13.0
Additional test coverage and some bug fixes for customizing certificate paths in containers
/cc @danegsta
Customer Impact
Testing
Risk
Regression?