Skip to content

[CI] Fix main build#14145

Merged
adamint merged 2 commits intomainfrom
copilot/fix-missing-telemetry-parameter
Jan 27, 2026
Merged

[CI] Fix main build#14145
adamint merged 2 commits intomainfrom
copilot/fix-missing-telemetry-parameter

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 27, 2026

Description

PR #13963 updated BaseCommand constructor to require AspireCliTelemetry telemetry parameter. ResourcesCommand and LogsCommand were not updated, breaking main branch builds with CS7036 errors.

Changes:

  • Added AspireCliTelemetry telemetry parameter to ResourcesCommand and LogsCommand constructors
  • Added using Aspire.Cli.Telemetry; directive to both files
  • Passed telemetry parameter to base constructor
public ResourcesCommand(
    IInteractionService interactionService,
    IAuxiliaryBackchannelMonitor backchannelMonitor,
    IFeatures features,
    ICliUpdateNotifier updateNotifier,
    CliExecutionContext executionContext,
    AspireCliTelemetry telemetry,  // Added
    ILogger<ResourcesCommand> logger)
    : base("resources", ResourcesCommandStrings.Description, features, updateNotifier, executionContext, interactionService, telemetry)  // Pass through

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • centralus-2.in.applicationinsights.azure.com
    • Triggering command: /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests --internal-msbuild-node /home/REDACTED/.local/share/136a9fd2fcba4471a93b9995a687af5e/.p --filter-not-trait category=failing --filter-not-trait quarantined=true --filter-not-trait outerloop=true (dns block)
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.deps.json /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Microsoft.DotNet.RemoteExecutor.dll Aspire.Cli.Tests, Version=42.42.42.42, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 Aspire.Cli.Tests.CliSmokeTests&#43;&lt;&gt;c &lt;LocaleOverrideReturnsExitCode&gt;b__1_0 /tmp/ato44hlk.3t3 invalid-locale False ASPIRE_LOCALE_OVERRIDE (dns block)
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.deps.json /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Microsoft.DotNet.RemoteExecutor.dll Aspire.Cli.Tests, Version=42.42.42.42, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 Aspire.Cli.Tests.CliSmokeTests&#43;&lt;&gt;c &lt;LocaleOverrideReturnsExitCode&gt;b__1_0 /tmp/kmc1wtxb.vc0 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Open an issue for this failure in https://github.com/dotnet/aspire/actions/runs/21406343091/job/61631188136 which is a rolling build for main:

/home/runner/work/aspire/aspire/src/Aspire.Cli/Commands/ResourcesCommand.cs(78,11): error CS7036: There is no argument given that corresponds to the required parameter 'telemetry' of 'BaseCommand.BaseCommand(string, string, IFeatures, ICliUpdateNotifier, CliExecutionContext, IInteractionService, AspireCliTelemetry)' [/home/runner/work/aspire/aspire/src/Aspire.Cli/Aspire.Cli.Tool.csproj]
/home/runner/work/aspire/aspire/src/Aspire.Cli/Commands/LogsCommand.cs(102,11): error CS7036: There is no argument given that corresponds to the required parameter 'telemetry' of 'BaseCommand.BaseCommand(string, string, IFeatures, ICliUpdateNotifier, CliExecutionContext, IInteractionService, AspireCliTelemetry)' [/home/runner/work/aspire/aspire/src/Aspire.Cli/Aspire.Cli.Tool.csproj]
/home/runner/work/aspire/aspire/src/Aspire.Cli/Commands/ResourcesCommand.cs(78,11): error CS7036: There is no argument given that corresponds to the required parameter 'telemetry' of 'BaseCommand.BaseCommand(string, string, IFeatures, ICliUpdateNotifier, CliExecutionContext, IInteractionService, AspireCliTelemetry)' [/home/runner/work/aspire/aspire/src/Aspire.Cli/Aspire.Cli.csproj]
/home/runner/work/aspire/aspire/src/Aspire.Cli/Commands/LogsCommand.cs(102,11): error CS7036: There is no argument given that corresponds to the required parameter 'telemetry' of 'BaseCommand.BaseCommand(string, string, IFeatures, ICliUpdateNotifier, CliExecutionContext, IInteractionService, AspireCliTelemetry)' [/home/runner/work/aspire/aspire/src/Aspire.Cli/Aspire.Cli.csproj]
/home/runner/work/aspire/aspire/src/Aspire.Cli/Commands/ResourcesCommand.cs(78,11): error CS7036: There is no argument given that corresponds to the required parameter 'telemetry' of 'BaseCommand.BaseCommand(string, string, IFeatures, ICliUpdateNotifier, CliExecutionContext, IInteractionService, AspireCliTelemetry)' [/home/runner/work/aspire/aspire/src/Aspire.Cli/Aspire.Cli.csproj]
/home/runner/work/aspire/aspire/src/Aspire.Cli/Commands/LogsCommand.cs(102,11): error CS7036: There is no argument given that corresponds to the required parameter 'telemetry' of 'BaseCommand.BaseCommand(string, string, IFeatures, ICliUpdateNotifier, CliExecutionContext, IInteractionService, AspireCliTelemetry)' [/home/runner/work/aspire/aspire/src/Aspire.Cli/Aspire.Cli.csproj]

Mention the PR the commit belonged to.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Add missing AspireCliTelemetry parameter to ResourcesCommand and LogsCommand constructors, and pass it to the BaseCommand base constructor. This fixes the build failures introduced by PR #13963 which added telemetry support to BaseCommand.

Co-authored-by: radical <1472+radical@users.noreply.github.com>
@radical radical marked this pull request as ready for review January 27, 2026 17:36
Copilot AI review requested due to automatic review settings January 27, 2026 17:36
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14145

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14145"

Copilot AI changed the title [WIP] Fix missing telemetry parameter in BaseCommand Fix missing telemetry parameter in ResourcesCommand and LogsCommand Jan 27, 2026
Copilot AI requested a review from radical January 27, 2026 17:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a build break in Aspire CLI commands after BaseCommand started requiring an AspireCliTelemetry constructor parameter (introduced in PR #13963).

Changes:

  • Add AspireCliTelemetry parameter to ResourcesCommand and pass it through to BaseCommand.
  • Add AspireCliTelemetry parameter to LogsCommand and pass it through to BaseCommand.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Aspire.Cli/Commands/ResourcesCommand.cs Injects and forwards AspireCliTelemetry to the BaseCommand constructor to fix missing-parameter build errors.
src/Aspire.Cli/Commands/LogsCommand.cs Injects and forwards AspireCliTelemetry to the BaseCommand constructor to fix missing-parameter build errors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@radical radical changed the title Fix missing telemetry parameter in ResourcesCommand and LogsCommand [CI] Fix main build Jan 27, 2026
@adamint adamint enabled auto-merge (squash) January 27, 2026 18:46
@adamint adamint merged commit 9e35d40 into main Jan 27, 2026
655 of 659 checks passed
@adamint adamint deleted the copilot/fix-missing-telemetry-parameter branch January 27, 2026 18:58
@dotnet-policy-service dotnet-policy-service Bot added this to the 13.2 milestone Jan 27, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants