Merged
Conversation
Add missing AspireCliTelemetry parameter to ResourcesCommand and LogsCommand constructors, and pass it to the BaseCommand base constructor. This fixes the build failures introduced by PR #13963 which added telemetry support to BaseCommand. Co-authored-by: radical <1472+radical@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14145Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14145" |
Copilot
AI
changed the title
[WIP] Fix missing telemetry parameter in BaseCommand
Fix missing telemetry parameter in ResourcesCommand and LogsCommand
Jan 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a build break in Aspire CLI commands after BaseCommand started requiring an AspireCliTelemetry constructor parameter (introduced in PR #13963).
Changes:
- Add
AspireCliTelemetryparameter toResourcesCommandand pass it through toBaseCommand. - Add
AspireCliTelemetryparameter toLogsCommandand pass it through toBaseCommand.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Cli/Commands/ResourcesCommand.cs | Injects and forwards AspireCliTelemetry to the BaseCommand constructor to fix missing-parameter build errors. |
| src/Aspire.Cli/Commands/LogsCommand.cs | Injects and forwards AspireCliTelemetry to the BaseCommand constructor to fix missing-parameter build errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
main build
adamint
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #13963 updated
BaseCommandconstructor to requireAspireCliTelemetry telemetryparameter.ResourcesCommandandLogsCommandwere not updated, breaking main branch builds with CS7036 errors.Changes:
AspireCliTelemetry telemetryparameter toResourcesCommandandLogsCommandconstructorsusing Aspire.Cli.Telemetry;directive to both filesChecklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
centralus-2.in.applicationinsights.azure.com/home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests --internal-msbuild-node /home/REDACTED/.local/share/136a9fd2fcba4471a93b9995a687af5e/.p --filter-not-trait category=failing --filter-not-trait quarantined=true --filter-not-trait outerloop=true(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.deps.json /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Microsoft.DotNet.RemoteExecutor.dll Aspire.Cli.Tests, Version=42.42.42.42, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 Aspire.Cli.Tests.CliSmokeTests+<>c <LocaleOverrideReturnsExitCode>b__1_0 /tmp/ato44hlk.3t3 invalid-locale False ASPIRE_LOCALE_OVERRIDE(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.deps.json /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Microsoft.DotNet.RemoteExecutor.dll Aspire.Cli.Tests, Version=42.42.42.42, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 Aspire.Cli.Tests.CliSmokeTests+<>c <LocaleOverrideReturnsExitCode>b__1_0 /tmp/kmc1wtxb.vc0(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.