Skip to content

Add telemetry to logs, resources, and ps commands#14163

Merged
davidfowl merged 1 commit intomainfrom
davidfowl/add-telemetry
Jan 28, 2026
Merged

Add telemetry to logs, resources, and ps commands#14163
davidfowl merged 1 commit intomainfrom
davidfowl/add-telemetry

Conversation

@davidfowl
Copy link
Copy Markdown
Contributor

Description

Adds telemetry support to the new CLI commands (logs, resources, ps) that were added in #14122. These commands were merged after the telemetry PR #13963, resulting in a build break due to missing AspireCliTelemetry parameter in the BaseCommand constructor.

Changes:

  • Added AspireCliTelemetry parameter to LogsCommand and ResourcesCommand constructors
  • Added diagnostic activity tracking to all three commands following the existing pattern

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copilot AI review requested due to automatic review settings January 28, 2026 03:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 28, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14163

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14163"

Comment thread src/Aspire.Cli/Commands/LogsCommand.cs Outdated
@davidfowl davidfowl force-pushed the davidfowl/add-telemetry branch from 3ad0afd to 1bc4b11 Compare January 28, 2026 04:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 28, 2026

🎬 CLI E2E Test Recordings

The following terminal recordings are available for commit 1bc4b11:

Test Recording
CreateAndDeployToDockerCompose ▶️ View Recording
CreateAndDeployToDockerComposeInteractive ▶️ View Recording
CreateAndRunAspireStarterProject ▶️ View Recording
CreateAndRunJsReactProject ▶️ View Recording
CreateAndRunPythonReactProject ▶️ View Recording
CreateEmptyAppHostProject ▶️ View Recording
CreateStartAndStopAspireProject ▶️ View Recording
CreateTypeScriptAppHostWithViteApp ▶️ View Recording
DoctorCommand_WithSslCertDir_ShowsTrusted ▶️ View Recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted ▶️ View Recording
PsCommandListsRunningAppHost ▶️ View Recording

📹 Recordings uploaded automatically from CI run #21424587340

@davidfowl davidfowl enabled auto-merge (squash) January 28, 2026 04:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@davidfowl davidfowl merged commit 1ef1172 into main Jan 28, 2026
333 checks passed
@davidfowl davidfowl deleted the davidfowl/add-telemetry branch January 28, 2026 04:32
@dotnet-policy-service dotnet-policy-service Bot added this to the 13.2 milestone Jan 28, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants