Add networkIsolationPolicy to 1ES pipeline templates for SFI-ES4.2.4 compliance#14696
Merged
joperezr merged 1 commit intorelease/13.2from Mar 12, 2026
Merged
Conversation
…compliance Add networkIsolationPolicy: Permissive,CFSClean2 to the 1ES pipeline template parameters in both official and unofficial pipeline definitions to resolve the [SFI-ES4.2.4] Network Isolation for CFS endpoints S360 KPI violation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14696Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14696" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the 1ES pipeline template parameter settings.networkIsolationPolicy: Permissive,CFSClean2 to address SFI-ES4.2.4 (CFS endpoint network isolation) compliance scanning requirements for the repo’s CI pipelines.
Changes:
- Add
settings.networkIsolationPolicy: Permissive,CFSClean2toeng/pipelines/azure-pipelines.yml(official pipeline). - Add the same
settings.networkIsolationPolicytoeng/pipelines/azure-pipelines-unofficial.yml(unofficial pipeline).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/azure-pipelines.yml | Passes settings.networkIsolationPolicy into the 1ES Official template parameters. |
| eng/pipelines/azure-pipelines-unofficial.yml | Passes settings.networkIsolationPolicy into the 1ES Unofficial template parameters. |
This was referenced Feb 26, 2026
mitchdenny
approved these changes
Mar 3, 2026
Member
mitchdenny
left a comment
There was a problem hiding this comment.
Looks good — purely a compliance declaration change with no functional impact on build behavior. The Permissive mode keeps outbound access open, and CFSClean2 satisfies the S360 scanner.
This was referenced Mar 3, 2026
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
networkIsolationPolicy: Permissive,CFSClean2to the 1ES pipeline template parameters to resolve the [SFI-ES4.2.4] "Network Isolation for CFS endpoints" S360 KPI violation (CFSClean violation type).Background
The S360 KPI [SFI-ES4.2.4] requires that CI/CD pipelines use Central Feed Service (CFS) package feeds, Azure Artifacts feeds, rather than public package registries, to enforce supply chain security and network isolation.
Our NuGet.config already exclusively uses Azure Artifacts/CFS-compliant feeds (all pointing to pkgs.dev.azure.com/dnceng or dnceng.pkgs.visualstudio.com). No public feeds like nuget.org are referenced. However, the 1ES pipeline template parameters were missing the
networkIsolationPolicydeclaration, which is what the compliance scanner checks for.What the setting means
Precedent
This is the same approach used by dotnet/source-indexer (see their azure-pipelines.yml), which previously had the same CFSClean violation and resolved it with this one-line setting.
Changes
eng/pipelines/azure-pipelines.yml- Addedsettings.networkIsolationPolicy: Permissive,CFSClean2underextends.parameterseng/pipelines/azure-pipelines-unofficial.yml- Same change applied