Add polyglot exports for Aspire.Hosting.Seq#14890
Merged
sebastienros merged 1 commit intorelease/13.2from Mar 3, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14890Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14890" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ATS/polyglot export coverage for the Aspire.Hosting.Seq integration so TypeScript AppHosts can consume the Seq resource APIs, plus a TypeScript validation AppHost to compile-check the generated SDK.
Changes:
- Annotate Seq extension methods with
[AspireExport]/[AspireExportIgnore]for polyglot capability generation. - Add a TypeScript
ValidationAppHostfor Aspire.Hosting.Seq (config + sample apphost) to validatetsc --noEmit. - Check in the generated
.modules/*TypeScript SDK output for the validation project.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Seq/SeqBuilderExtensions.cs | Adds ATS export metadata for AddSeq, WithDataVolume, and WithDataBindMount (and ignores a convenience overload). |
| playground/polyglot/TypeScript/Aspire.Hosting.Seq/ValidationAppHost/tsconfig.json | TypeScript compiler configuration for the validation AppHost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Seq/ValidationAppHost/package.json | Node/TS dependencies and scripts for the validation AppHost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Seq/ValidationAppHost/package-lock.json | Locked dependency graph for reproducible installs. |
| playground/polyglot/TypeScript/Aspire.Hosting.Seq/ValidationAppHost/apphost.ts | Sample TypeScript AppHost exercising the exported Seq APIs. |
| playground/polyglot/TypeScript/Aspire.Hosting.Seq/ValidationAppHost/apphost.run.json | Local run profile settings for the validation AppHost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Seq/ValidationAppHost/.modules/transport.ts | Generated ATS transport/runtime support. |
| playground/polyglot/TypeScript/Aspire.Hosting.Seq/ValidationAppHost/.modules/base.ts | Generated shared base types (handles, list/dict wrappers, reference expressions). |
| playground/polyglot/TypeScript/Aspire.Hosting.Seq/ValidationAppHost/.modules/aspire.ts | Generated capability-based TypeScript SDK including Seq bindings. |
| playground/polyglot/TypeScript/Aspire.Hosting.Seq/ValidationAppHost/.modules/.codegen-hash | Hash pinning the codegen output version/source. |
| playground/polyglot/TypeScript/Aspire.Hosting.Seq/ValidationAppHost/.aspire/settings.json | Aspire CLI settings enabling the TypeScript AppHost and package selection. |
Files not reviewed (1)
- playground/polyglot/TypeScript/Aspire.Hosting.Seq/ValidationAppHost/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
src/Aspire.Hosting.Seq/SeqBuilderExtensions.cs:50
adminPasswordis nullable but not optional in the exportedAddSeqsignature, so the generated TypeScript API requires an admin password and can’t represent the documented “no authentication” scenario without unsafe casts. Consider makingadminPasswordan optional parameter (e.g., defaulting tonull) or adding a separate exported overload/capability that disables authentication.
[AspireExport("addSeq", Description = "Adds a Seq server container resource")]
public static IResourceBuilder<SeqResource> AddSeq(
this IDistributedApplicationBuilder builder,
string name,
IResourceBuilder<ParameterResource>? adminPassword,
int? port = null)
76 tasks
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22636476967 |
IEvangelist
approved these changes
Mar 3, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add polyglot AspireExport coverage for Aspire.Hosting.Seq.
Related to #14069.
Validation:
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: