Add polyglot exports for Aspire.Hosting.Azure.ContainerRegistry#14903
Merged
davidfowl merged 3 commits intorelease/13.2from Mar 4, 2026
Merged
Add polyglot exports for Aspire.Hosting.Azure.ContainerRegistry#14903davidfowl merged 3 commits intorelease/13.2from
davidfowl merged 3 commits intorelease/13.2from
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14903Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14903" |
76 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial polyglot (TypeScript AppHost) export coverage for the Aspire.Hosting.Azure.ContainerRegistry integration and introduces a corresponding TypeScript ValidationAppHost playground to validate generated bindings.
Changes:
- Annotates
AddAzureContainerRegistryandWithPurgeTaskwith[AspireExport]for ATS/polyglot capability generation. - Adds a new
playground/polyglot/TypeScript/.../ValidationAppHostfor the integration, including generated.modulesruntime + SDK and Node/TS project files.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.ContainerRegistry/AzureContainerRegistryExtensions.cs | Adds [AspireExport] metadata for two ACR extension methods. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/tsconfig.json | TypeScript compiler configuration for the validation AppHost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/package.json | Node/TypeScript package setup for the validation AppHost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/package-lock.json | Dependency lockfile for reproducible installs. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/apphost.ts | Validation AppHost entrypoint (currently minimal). |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/apphost.run.json | Run profile configuration for the validation AppHost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.modules/transport.ts | Generated ATS transport/runtime support (RPC, handles, callbacks). |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.modules/base.ts | Generated shared SDK base types (reference expressions, collection wrappers). |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.modules/aspire.ts | Generated integration SDK surface for the validation AppHost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.modules/.codegen-hash | Tracks codegen version/hash for the generated .modules output. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.aspire/settings.json | Configures the validation AppHost as typescript/nodejs and references the package. |
Files not reviewed (1)
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/package-lock.json: Language not supported
src/Aspire.Hosting.Azure.ContainerRegistry/AzureContainerRegistryExtensions.cs
Outdated
Show resolved
Hide resolved
...ound/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/apphost.ts
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.ContainerRegistry/AzureContainerRegistryExtensions.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.ContainerRegistry/AzureContainerRegistryExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22646634705 |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
davidfowl
approved these changes
Mar 4, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Add polyglot exports for Aspire.Hosting.Azure.ContainerRegistry Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Refine AspireExport descriptions for polyglot-azure-containerregistry Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use generated methods in containerregistry apphost Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14069