Add polyglot exports for Aspire.Hosting.Oracle#14906
Merged
davidfowl merged 3 commits intorelease/13.2from Mar 4, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14906Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14906" |
76 tasks
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22649289206 |
- Add [AspireExport(ExposeProperties = true)] to OracleDatabaseServerResource and OracleDatabaseResource to expose properties to polyglot app hosts - Add [AspireExportIgnore] on ConnectionStringExpression for both resources - Update playground ValidationAppHost apphost.ts to exercise all exported methods: addOracle, addDatabase, withDataVolume, withDataBindMount, withInitFiles, withDbSetupBindMount, withReference, withServiceReference, fluent chaining, and property access - Regenerate TypeScript SDK with updated property accessors - Clean up settings.json (remove sdkVersion and package version) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
davidfowl
approved these changes
Mar 4, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Add polyglot exports for Aspire.Hosting.Oracle Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Refine AspireExport descriptions for polyglot-oracle Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add AspireExport property coverage for Oracle hosting integration - Add [AspireExport(ExposeProperties = true)] to OracleDatabaseServerResource and OracleDatabaseResource to expose properties to polyglot app hosts - Add [AspireExportIgnore] on ConnectionStringExpression for both resources - Update playground ValidationAppHost apphost.ts to exercise all exported methods: addOracle, addDatabase, withDataVolume, withDataBindMount, withInitFiles, withDbSetupBindMount, withReference, withServiceReference, fluent chaining, and property access - Regenerate TypeScript SDK with updated property accessors - Clean up settings.json (remove sdkVersion and package version) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14069