Add polyglot exports for Aspire.Hosting.Milvus#14909
Merged
davidfowl merged 3 commits intorelease/13.2from Mar 4, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14909Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14909" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds polyglot (TypeScript) export surface for Aspire.Hosting.Milvus and checks it via a TypeScript validation AppHost playground.
Changes:
- Added
[AspireExport]attributes to Milvus hosting extension methods to expose them to polyglot app hosts. - Introduced a TypeScript “ValidationAppHost” playground project for Milvus, including generated
.modulesruntime/helpers. - Added TS build/runtime configuration (
tsconfig.json,package.json, Aspire settings, run profile).
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Milvus/MilvusBuilderExtensions.cs | Exposes Milvus APIs to the polyglot export system via AspireExport attributes. |
| playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/tsconfig.json | Adds TS compiler configuration for the validation host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/package.json | Adds Node/TS project scaffolding for running and building the validation host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/apphost.ts | Minimal TypeScript app host entrypoint to exercise the generated modules. |
| playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/apphost.run.json | Adds local run profile/environment variables for the validation host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/.modules/transport.ts | Adds JSON-RPC transport client and handle/callback/cancellation infrastructure. |
| playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/.modules/base.ts | Adds base polyglot types (reference expressions, list/dict wrappers) and re-exports. |
| playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/.modules/.codegen-hash | Records codegen hash for generated module set. |
| playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/.aspire/settings.json | Configures Aspire polyglot settings to use the TS app host and Milvus package. |
Files not reviewed (1)
- playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/.modules/base.ts
Show resolved
Hide resolved
playground/polyglot/TypeScript/Aspire.Hosting.Milvus/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
76 tasks
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22649519238 |
- Add [AspireExport("withAttu")] to WithAttu method in MilvusBuilderExtensions
- Update TypeScript validation apphost to exercise all exported methods:
addMilvus, addDatabase, withAttu, withDataVolume, withDataBindMount,
withConfigurationFile, and withReference from core
- Regenerate TypeScript SDK with withAttu support
- Clean up settings.json (remove sdkVersion and package versions)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
davidfowl
reviewed
Mar 4, 2026
| .withAttu(); | ||
|
|
||
| // ── 15. withReference: use Milvus database from a container resource ─────── | ||
| const api = await builder.addContainer("api", "myregistry/myapp"); |
davidfowl
approved these changes
Mar 4, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Add polyglot exports for Aspire.Hosting.Milvus
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Refine AspireExport descriptions for polyglot-milvus
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add AspireExport to Milvus WithAttu and update validation apphost
- Add [AspireExport("withAttu")] to WithAttu method in MilvusBuilderExtensions
- Update TypeScript validation apphost to exercise all exported methods:
addMilvus, addDatabase, withAttu, withDataVolume, withDataBindMount,
withConfigurationFile, and withReference from core
- Regenerate TypeScript SDK with withAttu support
- Clean up settings.json (remove sdkVersion and package versions)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14069