Add polyglot exports for Aspire.Hosting.GitHub.Models#14910
Merged
davidfowl merged 5 commits intorelease/13.2from Mar 3, 2026
Merged
Add polyglot exports for Aspire.Hosting.GitHub.Models#14910davidfowl merged 5 commits intorelease/13.2from
davidfowl merged 5 commits intorelease/13.2from
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14910Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14910" |
76 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ATS/polyglot export annotations to Aspire.Hosting.GitHub.Models and introduces a TypeScript ValidationAppHost to validate generated SDK output for the integration (related to #14069).
Changes:
- Added
[AspireExport]annotations forAddGitHubModel,WithApiKey, andWithHealthCheck. - Added a new TypeScript ValidationAppHost scaffold (tsconfig/package/apphost/settings) for Aspire.Hosting.GitHub.Models.
- Added generated
.modules/*transport/base (and associated codegen hash) to support the ValidationAppHost.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.GitHub.Models/GitHubModelsExtensions.cs | Adds ATS export metadata for GitHub Models extension methods. |
| playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/tsconfig.json | TypeScript compiler configuration for the GitHub Models validation apphost. |
| playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/package.json | NPM scripts/deps for running/building the validation apphost. |
| playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/package-lock.json | Lockfile for the validation apphost dependencies. |
| playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/apphost.ts | Entry point for the TypeScript validation apphost. |
| playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/apphost.run.json | Run profile/environment variables for aspire run. |
| playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/.modules/transport.ts | Generated ATS transport layer used by the validation apphost SDK. |
| playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/.modules/base.ts | Generated base types/helpers for the validation apphost SDK. |
| playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/.modules/.codegen-hash | Tracks the codegen state for the generated .modules output. |
| playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/.aspire/settings.json | Configures the validation apphost language + referenced integration package. |
Files not reviewed (1)
- playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/apphost.ts
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22642298636 |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…lidationAppHost/apphost.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
davidfowl
approved these changes
Mar 3, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Add polyglot exports for Aspire.Hosting.GitHub.Models Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update src/Aspire.Hosting.GitHub.Models/GitHubModelsExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Aspire.Hosting.GitHub.Models/GitHubModelsExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refine AspireExport descriptions for polyglot-github-models Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update playground/polyglot/TypeScript/Aspire.Hosting.GitHub.Models/ValidationAppHost/apphost.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14069