Skip to content

Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast#14935

Merged
davidfowl merged 2 commits intofix-cli-testfrom
copilot/sub-pr-14934
Mar 5, 2026
Merged

Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast#14935
davidfowl merged 2 commits intofix-cli-testfrom
copilot/sub-pr-14934

Conversation

Copy link
Contributor

Copilot AI commented Mar 4, 2026

InstallAspireCliFromPullRequest was missed in the original fix (#14934) — it still used WaitForSuccessPrompt despite downloading from the GitHub API via curl, making it susceptible to the same HTTP 502 failures described in issue #14933.

Description

Changed WaitForSuccessPromptWaitForSuccessPromptFailFast in InstallAspireCliFromPullRequest to match the behavior of InstallAspireCliRelease and InstallAspireCliDaily.

// Before
.WaitForSuccessPrompt(counter, TimeSpan.FromSeconds(300));

// After
.WaitForSuccessPromptFailFast(counter, TimeSpan.FromSeconds(300));

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…lFast

Co-authored-by: radical <1472+radical@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on handling CLI download failures Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast Mar 4, 2026
@radical radical marked this pull request as ready for review March 4, 2026 16:23
@radical radical closed this Mar 4, 2026
@radical radical reopened this Mar 4, 2026
@davidfowl davidfowl merged commit 82690fa into fix-cli-test Mar 5, 2026
5 of 6 checks passed
@davidfowl davidfowl deleted the copilot/sub-pr-14934 branch March 5, 2026 04:45
radical added a commit that referenced this pull request Mar 5, 2026
* Fail fast when CLI download fails in E2E tests

Add WaitForSuccessPromptFailFast to Hex1bTestHelpers that watches for
both OK and ERR prompts. When the CLI artifact download fails (e.g.
HTTP 502), the test now throws immediately instead of waiting the full
5-minute timeout.

Updated InstallAspireCliFromPullRequest, InstallAspireCliVersion,
InstallAspireBundleFromPullRequest, and InstallAspireCliRelease to
use the new fail-fast method.

Fixes #14933

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast (#14935)

* Initial plan

* Update InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast

Co-authored-by: radical <1472+radical@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: radical <1472+radical@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: radical <1472+radical@users.noreply.github.com>
eerhardt pushed a commit to eerhardt/aspire that referenced this pull request Mar 7, 2026
* Fail fast when CLI download fails in E2E tests

Add WaitForSuccessPromptFailFast to Hex1bTestHelpers that watches for
both OK and ERR prompts. When the CLI artifact download fails (e.g.
HTTP 502), the test now throws immediately instead of waiting the full
5-minute timeout.

Updated InstallAspireCliFromPullRequest, InstallAspireCliVersion,
InstallAspireBundleFromPullRequest, and InstallAspireCliRelease to
use the new fail-fast method.

Fixes microsoft#14933

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast (microsoft#14935)

* Initial plan

* Update InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast

Co-authored-by: radical <1472+radical@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: radical <1472+radical@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: radical <1472+radical@users.noreply.github.com>
Copilot AI added a commit that referenced this pull request Mar 10, 2026
* Fail fast when CLI download fails in E2E tests

Add WaitForSuccessPromptFailFast to Hex1bTestHelpers that watches for
both OK and ERR prompts. When the CLI artifact download fails (e.g.
HTTP 502), the test now throws immediately instead of waiting the full
5-minute timeout.

Updated InstallAspireCliFromPullRequest, InstallAspireCliVersion,
InstallAspireBundleFromPullRequest, and InstallAspireCliRelease to
use the new fail-fast method.

Fixes #14933

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast (#14935)

* Initial plan

* Update InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast

Co-authored-by: radical <1472+radical@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: radical <1472+radical@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: radical <1472+radical@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants