Fix deployment E2E tests: add --language csharp to aspire init#14958
Merged
davidfowl merged 1 commit intorelease/13.2from Mar 5, 2026
Merged
Fix deployment E2E tests: add --language csharp to aspire init#14958davidfowl merged 1 commit intorelease/13.2from
davidfowl merged 1 commit intorelease/13.2from
Conversation
The aspire init command now shows a language selection prompt when multiple languages are available (C#, TypeScript). The 12 failing deployment tests did not handle this new prompt, causing them to timeout waiting for 'Aspire initialization complete'. Adding --language csharp explicitly skips the language prompt, restoring the expected test flow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14958Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14958" |
Contributor
|
🚀 Deployment tests starting on PR #14958... This will deploy to real Azure infrastructure. Results will be posted here when complete. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Aspire deployment end-to-end tests to make aspire init non-blocking now that the CLI can prompt for language selection when multiple AppHost languages are available.
Changes:
- Add
--language csharptoaspire initinvocations across the affected deployment E2E tests to bypass the new language prompt. - Restore the expected terminal automation flow so tests don’t time out waiting for initialization completion.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Deployment.EndToEnd.Tests/VnetStorageBlobInfraDeploymentTests.cs | Adds explicit C# language selection to aspire init in the VNet+Storage Blob infra flow. |
| tests/Aspire.Deployment.EndToEnd.Tests/VnetSqlServerInfraDeploymentTests.cs | Adds explicit C# language selection to aspire init in the VNet+SQL Server infra flow. |
| tests/Aspire.Deployment.EndToEnd.Tests/VnetKeyVaultInfraDeploymentTests.cs | Adds explicit C# language selection to aspire init in the VNet+Key Vault infra flow. |
| tests/Aspire.Deployment.EndToEnd.Tests/AzureStorageDeploymentTests.cs | Adds explicit C# language selection to aspire init to avoid the language prompt during setup. |
| tests/Aspire.Deployment.EndToEnd.Tests/AzureServiceBusDeploymentTests.cs | Adds explicit C# language selection to aspire init to keep terminal automation deterministic. |
| tests/Aspire.Deployment.EndToEnd.Tests/AzureLogAnalyticsDeploymentTests.cs | Adds explicit C# language selection to aspire init to prevent interactive blocking. |
| tests/Aspire.Deployment.EndToEnd.Tests/AzureKeyVaultDeploymentTests.cs | Adds explicit C# language selection to aspire init to avoid new prompt-induced timeouts. |
| tests/Aspire.Deployment.EndToEnd.Tests/AzureEventHubsDeploymentTests.cs | Adds explicit C# language selection to aspire init to restore expected flow. |
| tests/Aspire.Deployment.EndToEnd.Tests/AzureContainerRegistryDeploymentTests.cs | Adds explicit C# language selection to aspire init to prevent hanging at language selection. |
| tests/Aspire.Deployment.EndToEnd.Tests/AzureAppConfigDeploymentTests.cs | Adds explicit C# language selection to aspire init to skip language prompt. |
| tests/Aspire.Deployment.EndToEnd.Tests/AcaDeploymentErrorOutputTests.cs | Adds explicit C# language selection to aspire init in the ACA error-output scenario. |
| tests/Aspire.Deployment.EndToEnd.Tests/AcaCompactNamingDeploymentTests.cs | Adds explicit C# language selection to aspire init in the compact naming scenario. |
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
eerhardt
temporarily deployed
to
deployment-testing
GitHub Actions
Inactive
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22696857726 |
Contributor
|
✅ Deployment E2E Tests passed Summary: 25 passed, 0 failed, 0 cancelled Passed Tests
🎬 Terminal Recordings
|
Member
Author
davidfowl
approved these changes
Mar 5, 2026
eerhardt
added a commit
to eerhardt/aspire
that referenced
this pull request
Mar 7, 2026
…soft#14958) The aspire init command now shows a language selection prompt when multiple languages are available (C#, TypeScript). The 12 failing deployment tests did not handle this new prompt, causing them to timeout waiting for 'Aspire initialization complete'. Adding --language csharp explicitly skips the language prompt, restoring the expected test flow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
The aspire init command now shows a language selection prompt when multiple languages are available (C#, TypeScript). The 12 failing deployment tests did not handle this new prompt, causing them to timeout waiting for 'Aspire initialization complete'. Adding --language csharp explicitly skips the language prompt, restoring the expected test flow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes 12 broken deployment E2E tests that were timing out during
aspire init.Root cause: The
aspire initcommand now shows a language selection prompt ("Which language would you like to use?") when multiple languages are available (C#, TypeScript). The failing tests did not handle this new prompt, causing them to timeout waiting for "Aspire initialization complete" after 2 minutes.Fix: Add
--language csharpto allaspire initcalls in the 12 affected tests. This explicitly skips the language selection prompt, restoring the expected test flow.Affected tests:
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: