[release/13.2] Hide staging channel from aspire update --self when feature flag is disabled#14997
Merged
davidfowl merged 2 commits intorelease/13.2from Mar 6, 2026
Merged
Conversation
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14997Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14997" |
Contributor
Author
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22752267123 |
…isabled When the stagingChannelEnabled feature flag is not set, the staging channel is now excluded from the channel selection prompt in `aspire update --self`. Previously, staging was always shown regardless of the feature flag, which caused failures when users selected it. Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
davidfowl
force-pushed
the
backport/pr-14675-to-release/13.2
branch
from
8857aa3 to
fb455c1
Compare
davidfowl
approved these changes
Mar 6, 2026
JamesNK
approved these changes
Mar 6, 2026
eerhardt
pushed a commit
to eerhardt/aspire
that referenced
this pull request
Mar 7, 2026
…feature flag is disabled (microsoft#14997) * Initial plan * Hide staging channel from aspire update --self when feature flag is disabled When the stagingChannelEnabled feature flag is not set, the staging channel is now excluded from the channel selection prompt in `aspire update --self`. Previously, staging was always shown regardless of the feature flag, which caused failures when users selected it. Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot AI
added a commit
that referenced
this pull request
Mar 10, 2026
…feature flag is disabled (#14997) * Initial plan * Hide staging channel from aspire update --self when feature flag is disabled When the stagingChannelEnabled feature flag is not set, the staging channel is now excluded from the channel selection prompt in `aspire update --self`. Previously, staging was always shown regardless of the feature flag, which caused failures when users selected it. Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #14675 to release/13.2.
aspire update --selfunconditionally offered "staging" in the channel selection prompt, regardless of thestagingChannelEnabledfeature flag. Selecting it without the flag would fail since no staging channel exists.The fix checks
_features.IsFeatureEnabled(KnownFeatures.StagingChannelEnabled)before including staging in the prompt choices — consistent with how the channel option description andPackagingService.GetChannelsAsyncalready gate on this flag.Fixes #14648
Customer Impact
Users running
aspire update --selfwithout the staging feature flag enabled would see "staging" as a channel option. Selecting it would fail with an error about no staging channel being found.Testing
Two new unit tests added:
SelfUpdate_WithStagingDisabled_DoesNotOfferStagingChannelSelfUpdate_WithStagingEnabled_OffersStagingChannelRisk
Low — only changes the channel list filtering in the self-update prompt.
Checklist