Enhance aspire sdk dump#15005
Merged
IEvangelist merged 2 commits intosdk-dump-enchancementsfrom Mar 6, 2026
Merged
Conversation
…ovements, allAdditionalSources cleanup Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
IEvangelist
approved these changes
Mar 6, 2026
IEvangelist
added a commit
that referenced
this pull request
Mar 6, 2026
* Enhance aspire sdk dump: multi-integration args, PackageName@Version support, and DTO field descriptions * Enhance SdkDumpCommand validation for package format and version, add tests for command behavior * Enhance `aspire sdk dump` (#15005) * Initial plan * Address PR review feedback: --format option, debug logging, test improvements, allAdditionalSources cleanup Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
radical
pushed a commit
that referenced
this pull request
Mar 6, 2026
* Enhance aspire sdk dump: multi-integration args, PackageName@Version support, and DTO field descriptions * Enhance SdkDumpCommand validation for package format and version, add tests for command behavior * Enhance `aspire sdk dump` (#15005) * Initial plan * Address PR review feedback: --format option, debug logging, test improvements, allAdditionalSources cleanup Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
eerhardt
pushed a commit
to eerhardt/aspire
that referenced
this pull request
Mar 7, 2026
* Enhance aspire sdk dump: multi-integration args, PackageName@Version support, and DTO field descriptions * Enhance SdkDumpCommand validation for package format and version, add tests for command behavior * Enhance `aspire sdk dump` (microsoft#15005) * Initial plan * Address PR review feedback: --format option, debug logging, test improvements, allAdditionalSources cleanup Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Copilot AI
added a commit
that referenced
this pull request
Mar 10, 2026
* Enhance aspire sdk dump: multi-integration args, PackageName@Version support, and DTO field descriptions * Enhance SdkDumpCommand validation for package format and version, add tests for command behavior * Enhance `aspire sdk dump` (#15005) * Initial plan * Address PR review feedback: --format option, debug logging, test improvements, allAdditionalSources cleanup Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses PR review feedback on the
aspire sdk dumpenhancements. Cleans up the format option API, adds diagnostic logging, and fixes minor code quality issues.Description
--format <value>replaces--json/--ciflagsConsolidates two boolean flags into a single
--formatoption consistent with other CLI commands (ps,describe,mcp tools, etc.):Accepts
Pretty(default),Json, orCi— case-insensitive.Other fixes
AtsCapabilityScanner: Log viaDebug.WriteLinewhen a malformed XML doc file is encountered (previously silently swallowed).DotNetBasedAppHostServerProject: Remove unnecessaryallAdditionalSources = new List<string>(channelSources)copy — usechannelSourcesdirectly.AtsCapabilityScannerTests: AddAssert.NotNull(first)beforeAssert.Samein the XML doc cache test to prevent a vacuous pass when the XML file isn't present.SdkDumpCommandTests: Replace the now-obsolete--json --ciconflict test with a parameterized theory covering all valid--formatvalues and case variants.Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.