Skip to content

Enhance aspire sdk dump#15005

Merged
IEvangelist merged 2 commits intosdk-dump-enchancementsfrom
copilot/sub-pr-15004
Mar 6, 2026
Merged

Enhance aspire sdk dump#15005
IEvangelist merged 2 commits intosdk-dump-enchancementsfrom
copilot/sub-pr-15004

Conversation

Copy link
Contributor

Copilot AI commented Mar 6, 2026

Addresses PR review feedback on the aspire sdk dump enhancements. Cleans up the format option API, adds diagnostic logging, and fixes minor code quality issues.

Description

--format <value> replaces --json/--ci flags

Consolidates two boolean flags into a single --format option consistent with other CLI commands (ps, describe, mcp tools, etc.):

aspire sdk dump --format json                    # machine-readable JSON
aspire sdk dump --format ci -o capabilities.txt  # stable text for diffing
aspire sdk dump                                  # default pretty output

Accepts Pretty (default), Json, or Ci — case-insensitive.

Other fixes

  • AtsCapabilityScanner: Log via Debug.WriteLine when a malformed XML doc file is encountered (previously silently swallowed).
  • DotNetBasedAppHostServerProject: Remove unnecessary allAdditionalSources = new List<string>(channelSources) copy — use channelSources directly.
  • AtsCapabilityScannerTests: Add Assert.NotNull(first) before Assert.Same in the XML doc cache test to prevent a vacuous pass when the XML file isn't present.
  • SdkDumpCommandTests: Replace the now-obsolete --json --ci conflict test with a parameterized theory covering all valid --format values and case variants.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…ovements, allAdditionalSources cleanup

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Copilot AI changed the title [WIP] Enhance aspire sdk dump Enhance aspire sdk dump Mar 6, 2026
@IEvangelist IEvangelist marked this pull request as ready for review March 6, 2026 17:30
@IEvangelist IEvangelist requested a review from mitchdenny as a code owner March 6, 2026 17:30
@IEvangelist IEvangelist merged commit b4ea666 into sdk-dump-enchancements Mar 6, 2026
3 of 4 checks passed
@IEvangelist IEvangelist deleted the copilot/sub-pr-15004 branch March 6, 2026 17:31
IEvangelist added a commit that referenced this pull request Mar 6, 2026
* Enhance aspire sdk dump: multi-integration args, PackageName@Version support, and DTO field descriptions

* Enhance SdkDumpCommand validation for package format and version, add tests for command behavior

* Enhance `aspire sdk dump` (#15005)

* Initial plan

* Address PR review feedback: --format option, debug logging, test improvements, allAdditionalSources cleanup

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
radical pushed a commit that referenced this pull request Mar 6, 2026
* Enhance aspire sdk dump: multi-integration args, PackageName@Version support, and DTO field descriptions

* Enhance SdkDumpCommand validation for package format and version, add tests for command behavior

* Enhance `aspire sdk dump` (#15005)

* Initial plan

* Address PR review feedback: --format option, debug logging, test improvements, allAdditionalSources cleanup

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
eerhardt pushed a commit to eerhardt/aspire that referenced this pull request Mar 7, 2026
* Enhance aspire sdk dump: multi-integration args, PackageName@Version support, and DTO field descriptions

* Enhance SdkDumpCommand validation for package format and version, add tests for command behavior

* Enhance `aspire sdk dump` (microsoft#15005)

* Initial plan

* Address PR review feedback: --format option, debug logging, test improvements, allAdditionalSources cleanup

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Copilot AI added a commit that referenced this pull request Mar 10, 2026
* Enhance aspire sdk dump: multi-integration args, PackageName@Version support, and DTO field descriptions

* Enhance SdkDumpCommand validation for package format and version, add tests for command behavior

* Enhance `aspire sdk dump` (#15005)

* Initial plan

* Address PR review feedback: --format option, debug logging, test improvements, allAdditionalSources cleanup

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants