Skip to content

Fix failing test after log message updated to reference aka.ms/aspire/devcerts#15043

Merged
danegsta merged 2 commits intodanegsta/trustLogfrom
copilot/sub-pr-14666
Mar 7, 2026
Merged

Fix failing test after log message updated to reference aka.ms/aspire/devcerts#15043
danegsta merged 2 commits intodanegsta/trustLogfrom
copilot/sub-pr-14666

Conversation

Copy link
Contributor

Copilot AI commented Mar 7, 2026 •
edited
Loading

After updating the untrusted dev cert warning messages to replace dotnet dev-certs command instructions with See https://aka.ms/aspire/devcerts for more information., the test DcpHost_WithUntrustedDeveloperCertificate_ShowsNotificationAndLogsWarning was asserting the log message contained the appHostDirectory path — which is no longer included in the new message format.

Changes:

  • Remove now-unnecessary appHostDirectory/configuration setup (with AppHost:Directory) from the test
  • Replace string.Format assertion (which was substituting {0} with the path) with a direct equality check against InteractionStrings.DeveloperCertificateNotFullyTrustedMessage
  • Update the log content assertion to verify aka.ms/aspire/devcerts URL is present instead of appHostDirectory

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Mar 7, 2026
Merged
16 tasks
@danegsta
Fix failing test that was checking for outdated string content after …
db92275 
…log message update

Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Copilot AI changed the title [WIP] Add logging for untrusted dev cert in app host Fix failing test after log message updated to reference aka.ms/aspire/devcerts Mar 7, 2026
@danegsta danegsta marked this pull request as ready for review March 7, 2026 21:25
@danegsta danegsta requested a review from mitchdenny as a code owner March 7, 2026 21:25
@danegsta danegsta merged commit db607d3 into danegsta/trustLog Mar 7, 2026
3 of 4 checks passed
@danegsta danegsta deleted the copilot/sub-pr-14666 branch March 7, 2026 21:25
danegsta added a commit that referenced this pull request Mar 9, 2026
@danegsta
@DamianEdwards
Add logging if we detect the app host is running with an untrusted de…
542c3f5 
…v cert (#14666)

* Add logging if we detect the app host is running with an untrusted dev cert

* Allow overriding the dev cert used by the dashboard

* Also notify the dashboard if the certificate isn't trusted

* Update src/Aspire.Hosting/DeveloperCertificateService.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Move forward unlocking the macos keychain and trust the cert

* Update trust check to handle MacOS

* Add link to dev-certs code

* Cleanup some of the exceptions

* Trusting on Mac isn't going to be an option; switch to a warning in logs

* Use resource strings, move check and logging to DcpHost setup

* Update how HTTPS check is determined

* Use the file system service to get a temp folder

* Refactor DeveloperCertificateService to use ProcessSpec and ProcessUtil APIs with async/await (#14110)

* Update test service mocks

* Guard against the interaction service not being available

* Fix merge issue in DashboardEventHandlers

* Fix developer cert service timeout on Mac CI

* Only skip interaction service prompt if service not available

* Add additional test

* Fix failing test

* Disable dev cert https in mac ci tests

* Revert unrequired macos timeout change

* Add comments explaining the dashboard certificate config

* Only warn if there's an HTTPS/TLS endpoint

* Cleanup how we determine certificate trust to a cross-platform approach

* Expose interface property such that it can be used in tests

* Add chain build that got removed

* Check if cert is in root store on Windows

* Fix check that wasn't properly detecting the lack of trusted certificates

* Update src/Aspire.Hosting/Dcp/DcpHost.cs

Co-authored-by: Damian Edwards <damian@damianedwards.com>

* Add logging if we detect the app host is running with an untrusted dev cert (#15042)

* Initial plan

* Replace dotnet dev-certs command references with aka.ms/aspire/devcerts link

Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

* Fix failing test after log message updated to reference aka.ms/aspire/devcerts (#15043)

* Initial plan

* Fix failing test that was checking for outdated string content after log message update

Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

* Replace "ASP.NET Core Development Certificate" with "development certificate" in user-facing strings (#15048)

* Initial plan

* Replace "ASP.NET Core Development Certificate" with "development certificate" in strings

Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Damian Edwards <damian@damianedwards.com>
Copilot AI added a commit that referenced this pull request Mar 10, 2026
@danegsta
@DamianEdwards
Add logging if we detect the app host is running with an untrusted de…
4026fb8 
…v cert (#14666)

* Add logging if we detect the app host is running with an untrusted dev cert

* Allow overriding the dev cert used by the dashboard

* Also notify the dashboard if the certificate isn't trusted

* Update src/Aspire.Hosting/DeveloperCertificateService.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Move forward unlocking the macos keychain and trust the cert

* Update trust check to handle MacOS

* Add link to dev-certs code

* Cleanup some of the exceptions

* Trusting on Mac isn't going to be an option; switch to a warning in logs

* Use resource strings, move check and logging to DcpHost setup

* Update how HTTPS check is determined

* Use the file system service to get a temp folder

* Refactor DeveloperCertificateService to use ProcessSpec and ProcessUtil APIs with async/await (#14110)

* Update test service mocks

* Guard against the interaction service not being available

* Fix merge issue in DashboardEventHandlers

* Fix developer cert service timeout on Mac CI

* Only skip interaction service prompt if service not available

* Add additional test

* Fix failing test

* Disable dev cert https in mac ci tests

* Revert unrequired macos timeout change

* Add comments explaining the dashboard certificate config

* Only warn if there's an HTTPS/TLS endpoint

* Cleanup how we determine certificate trust to a cross-platform approach

* Expose interface property such that it can be used in tests

* Add chain build that got removed

* Check if cert is in root store on Windows

* Fix check that wasn't properly detecting the lack of trusted certificates

* Update src/Aspire.Hosting/Dcp/DcpHost.cs

Co-authored-by: Damian Edwards <damian@damianedwards.com>

* Add logging if we detect the app host is running with an untrusted dev cert (#15042)

* Initial plan

* Replace dotnet dev-certs command references with aka.ms/aspire/devcerts link

Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

* Fix failing test after log message updated to reference aka.ms/aspire/devcerts (#15043)

* Initial plan

* Fix failing test that was checking for outdated string content after log message update

Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

* Replace "ASP.NET Core Development Certificate" with "development certificate" in user-facing strings (#15048)

* Initial plan

* Replace "ASP.NET Core Development Certificate" with "development certificate" in strings

Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Damian Edwards <damian@damianedwards.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees

@danegsta danegsta

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danegsta