Quarantine Docker and Kubernetes E2E tests on release/13.2#15512
Quarantine Docker and Kubernetes E2E tests on release/13.2#15512mitchdenny merged 2 commits intorelease/13.2from
Conversation
SuppressFinalPackageVersion=true packages get assembly version 42.42.42.42 while stable packages resolve from nuget.org with 13.2.0.0, causing CS1705 and NU1102 errors on release branches. Tracking issue: #15511 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15512Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15512" |
There was a problem hiding this comment.
Pull request overview
This PR quarantines specific Aspire CLI end-to-end tests (Docker deployment and Kubernetes publish) on release/13.2 to avoid known failures caused by package/assembly version mismatches when SuppressFinalPackageVersion=true packages interact with stabilized release versions.
Changes:
- Marked the Docker Compose deployment E2E tests as quarantined with a link to issue #15511.
- Marked the Kubernetes publish-to-KinD/Helm E2E test as quarantined with a link to issue #15511.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/Aspire.Cli.EndToEnd.Tests/DockerDeploymentTests.cs | Quarantines Docker deployment E2E tests that are currently failing due to versioning mismatch on release/13.2. |
| tests/Aspire.Cli.EndToEnd.Tests/KubernetesPublishTests.cs | Quarantines the Kubernetes publish E2E test that is currently failing due to versioning mismatch on release/13.2. |
| [Fact] | ||
| [QuarantinedTest("https://github.com/microsoft/aspire/issues/15511")] | ||
| public async Task CreateAndPublishToKubernetes() |
There was a problem hiding this comment.
QuarantinedTest is in the Aspire.TestUtilities namespace; this file currently doesn't import it, so the new attribute will be an unresolved type at compile time. Add using Aspire.TestUtilities; (or fully qualify the attribute).
| [Fact] | ||
| [QuarantinedTest("https://github.com/microsoft/aspire/issues/15511")] | ||
| public async Task CreateAndDeployToDockerCompose() |
There was a problem hiding this comment.
QuarantinedTest is defined in the Aspire.TestUtilities namespace, but this file doesn't import it (unlike other E2E tests). As written, this will fail to compile with an unresolved attribute type; add using Aspire.TestUtilities; (or fully-qualify the attribute).
| [Fact] | ||
| [QuarantinedTest("https://github.com/microsoft/aspire/issues/15511")] | ||
| public async Task CreateAndDeployToDockerComposeInteractive() |
There was a problem hiding this comment.
Same issue as above: QuarantinedTest isn't in scope in this file, so this attribute usage will not compile unless you add using Aspire.TestUtilities; (or fully qualify the attribute).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Merging to unblock CI, and importantly PR #15504 |
Quarantines the Docker deployment and Kubernetes publish E2E tests on
release/13.2due to a versioning mismatch withSuppressFinalPackageVersion=truepackages.Root Cause
On
release/13.2,StabilizePackageVersion=truecreates a version split:Aspire.Hosting): version13.2.0, assembly version13.2.0.0(from nuget.org)SuppressFinalPackageVersion=true, e.g.Aspire.Hosting.Docker,Aspire.Hosting.Kubernetes): version13.2.0-ci, assembly version42.42.42.42This causes:
42.42.42.42vs13.2.0.0)13.2.0-cidoesn't satisfy>= 13.2.0-preview.1.xconstraintChanges
Added
[QuarantinedTest("https://github.com/microsoft/aspire/issues/15511")]to:DockerDeploymentTests.CreateAndDeployToDockerCompose()DockerDeploymentTests.CreateAndDeployToDockerComposeInteractive()KubernetesPublishTests.CreateAndPublishToKubernetes()Fixes #15511