Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs:235
- There is an inconsistency in the terminology used in documentation. In this method the term 'terminal state' is used, whereas in the related overload documentation another file refers to 'unhealthy terminal state'. Consider standardizing the phrasing for clarity.
/// If the resource enters a terminal state such as <see cref="KnownResourceStates.FailedToStart"/> then
src/Aspire.Hosting/ResourceBuilderExtensions.cs:737
- The XML comment here uses 'unhealthy terminal state' while similar documentation in ResourceNotificationService.cs uses 'terminal state'. Aligning the language across methods would improve consistency.
/// will throw a <see cref="DistributedApplicationException"/> if the resource enters an unhealthy terminal state.
danmoseley
reviewed
Feb 21, 2025
src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs
Outdated
Show resolved
Hide resolved
danmoseley
approved these changes
Feb 21, 2025
…e.cs Co-authored-by: Dan Moseley <danmose@microsoft.com>
JamesNK
approved these changes
Feb 21, 2025
Member
JamesNK
left a comment
There was a problem hiding this comment.
terminal -> unavailable
I think this is better because the enum option uses the word "Unavailable" and that's more accurate because logic includes some non terminal states.
src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: James Newton-King <james@newtonking.com>
…e.cs Co-authored-by: James Newton-King <james@newtonking.com>
…e.cs Co-authored-by: James Newton-King <james@newtonking.com>
…e.cs Co-authored-by: James Newton-King <james@newtonking.com>
eerhardt
reviewed
Feb 21, 2025
src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Feb 21, 2025
src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Feb 21, 2025
src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Feb 21, 2025
Comment on lines
+264
to
+265
| /// then the method will continue to wait until the resource reaches a <see cref="KnownResourceStates.Running"/> state. This is the default | ||
| /// behavior with the <see cref="WaitForResourceHealthyAsync(string, CancellationToken)"/> overload. |
Member
There was a problem hiding this comment.
Suggested change
| /// then the method will continue to wait until the resource reaches a <see cref="KnownResourceStates.Running"/> state. This is the default | |
| /// behavior with the <see cref="WaitForResourceHealthyAsync(string, CancellationToken)"/> overload. | |
| /// then the method will continue to wait until the resource reaches a <see cref="KnownResourceStates.Running"/> state. |
I would remove this sentence since:
- It is about a different method than what we are documenting here.
- It isn't accurate since the ResourceNotificationServiceOptions.DefaultWaitBehavior can (and will) change the behavior of that method.
…e.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…e.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…e.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Member
Author
|
/backport to release/9.1 |
Contributor
|
Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13466532044 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance clarity and detail in XML documentation comments for resource health checks and wait behaviors.