Skip to content

Conversation

@codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented May 18, 2024

Details

Axe.Windows follows semantic versioning, which states:

Given a version number MAJOR.MINOR.PATCH, increment the... MINOR version when you add functionality in a backward compatible manner

I think 6d72b85 and d2a5c65 qualify as "new functionality" for these purposes, justifying a minor version bump.

Also includes a small fix-up of #1020 to prevent execution of a11yProperty.ToSize on properties other than LogicalSize.

Motivation

Pre-release preparation.

Pull request checklist

  • [n/a] Addresses an existing issue: #0000

@codeofdusk codeofdusk requested a review from a team as a code owner May 18, 2024 20:13
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.16%. Comparing base (4fc19c3) to head (d5e1442).
Report is 386 commits behind head on main.

Current head d5e1442 differs from pull request most recent head bef734e

Please upload reports for the commit bef734e to get more accurate results.

Files Patch % Lines
src/Core/Misc/ExtensionMethods.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
- Coverage   73.70%   72.16%   -1.54%     
==========================================
  Files         398      424      +26     
  Lines       12046    13217    +1171     
  Branches        0     1421    +1421     
==========================================
+ Hits         8878     9538     +660     
- Misses       3168     3263      +95     
- Partials        0      416     +416     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeofdusk codeofdusk changed the title Chore: Bump minor version in preparation for release Chore: Bump minor version in preparation for release, fix-up #1020 May 18, 2024
@codeofdusk
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codeofdusk codeofdusk merged commit c6cfd71 into microsoft:main May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants