Skip to content

[1.0-dev] Remove "::set-env" commands in GitHub Actions for CVE-2020-15228 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9 commits merged into from
Oct 7, 2020
+3 −3
Merged

[1.0-dev] Remove "::set-env" commands in GitHub Actions for CVE-2020-15228 #178

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f0dcfe8
Remove ::set-env command
oliviacrain Oct 6, 2020
d02f7a9
Test push for check-package-cgmanifest.yml
oliviacrain Oct 6, 2020
29208cf
Revert "Test push for check-package-cgmanifest.yml"
oliviacrain Oct 6, 2020
12fd6b3
Testing changes for check-package-cgmanifest
oliviacrain Oct 6, 2020
6b6e5cb
Test push for check-package-cgmanifest.yml
oliviacrain Oct 6, 2020
696c486
Revert "Test push for check-package-cgmanifest.yml"
oliviacrain Oct 6, 2020
8b417c3
Revert "Testing changes for check-package-cgmanifest"
oliviacrain Oct 6, 2020
3670830
Test PR functionality
oliviacrain Oct 6, 2020
5f53716
Revert "Test PR functionality"
oliviacrain Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/check-package-cgmanifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,22 @@ jobs:
if: ${{ github.event_name == 'pull_request' }}
run: |
git fetch origin ${{ github.base_ref }}
echo "::set-env name=base_sha::$(git rev-parse origin/${{ github.base_ref }})"
echo "base_sha=$(git rev-parse origin/${{ github.base_ref }})" >> $GITHUB_ENV
echo "Merging ${{ github.sha }} into ${{ github.base_ref }}"

- name: Get base commit for Pushes
if: ${{ github.event_name == 'push' }}
run: |
git fetch origin ${{ github.event.before }}
echo "::set-env name=base_sha::${{ github.event.before }}"
echo "base_sha=${{ github.event.before }}" >> $GITHUB_ENV
echo "Merging ${{ github.sha }} into ${{ github.event.before }}"

- name: Get the changed files
run: |
echo "Files changed: '$(git diff-tree --no-commit-id --name-only -r ${{ env.base_sha }} ${{ github.sha }})'"
changed_specs=$(git diff-tree --no-commit-id --name-only -r ${{ env.base_sha }} ${{ github.sha }} | { grep "\.spec$" || test $? = 1; })
echo "Files to validate: '${changed_specs}'"
echo "::set-env name=updated-specs::$(echo ${changed_specs})"
echo "updated-specs=$(echo ${changed_specs})" >> $GITHUB_ENV

- name: Check each spec
run: |
Expand Down