Skip to content

[dev] Remove "::set-env" commands in GitHub Actions for CVE-2020-15228#179

Merged
1 commit merged intodevfrom
thcrain/workflow-set-env-fix-dev
Oct 7, 2020
Merged

[dev] Remove "::set-env" commands in GitHub Actions for CVE-2020-15228#179
1 commit merged intodevfrom
thcrain/workflow-set-env-fix-dev

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 6, 2020

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patches CVE-2020-15228 in our GitHub Actions scripts using the "::set-env" command (corresponds to PR against 1.0-dev branch #178)

Change Log
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Tested push functionality in thcrain/test-workflow-set-env branch, tested PR functionality in thcrain/test-workflow-set-env-fix branch
  • Both functioned as expected post-change

@ghost ghost merged commit a2e98e3 into dev Oct 7, 2020
@ghost ghost deleted the thcrain/workflow-set-env-fix-dev branch October 7, 2020 15:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants