Skip to content

Enable spec-lint action in dev branch#190

Merged
1 commit merged intodevfrom
thcrain/cherrypick-speclint-to-dev
Oct 19, 2020
Merged

Enable spec-lint action in dev branch#190
1 commit merged intodevfrom
thcrain/cherrypick-speclint-to-dev

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 9, 2020

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Cherry-pick spec-lint github action to dev branch from main (#172)

Change Log
  • Enable linting for modified spec files
  • Set to not block PRs for a short test period
  • Adds cgmanifest.json file in the .github/workflows folder
Does this affect the toolchain?

NO

Test Methodology
  • Pipeline build id: Action validated in private fork

* Initial spec-cleaner commit for CBL-Mariner

* Add cgmanifest.json file for GitHub workflows folder

* Set continue-on-error to true for a trial period
@ghost ghost requested a review from jslobodzian October 9, 2020 21:06
Copy link
Copy Markdown
Collaborator

@jslobodzian jslobodzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost ghost merged commit 20d9689 into dev Oct 19, 2020
@ghost ghost deleted the thcrain/cherrypick-speclint-to-dev branch October 19, 2020 22:28
henryli001 pushed a commit that referenced this pull request Feb 25, 2022
* Initial spec-cleaner commit for CBL-Mariner

* Add cgmanifest.json file for GitHub workflows folder

* Set continue-on-error to true for a trial period
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants