Skip to content

Remove implicit git repository dependency from toolkit #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrgirgin merged 2 commits into from
Oct 15, 2020
Merged

Remove implicit git repository dependency from toolkit #197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03ed70d
Remove implicit git repository dependency
mrgirgin Oct 12, 2020
903451f
Remove the new GIT_REV variable
mrgirgin Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions toolkit/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ TLS_KEY ?=
# Build defines
DIST_TAG ?= .cm1
BUILD_NUMBER ?= $(shell git rev-parse --short HEAD)
# an empty BUILD_NUMBER breaks the build later on
ifeq ($(BUILD_NUMBER),)
BUILD_NUMBER = non-git
endif
RELEASE_MAJOR_ID ?= 1.0
# use minor ID defined in file (if exist) otherwise define it
# note this file must be single line
Expand Down