Update package-lock.json after bumping packages #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenotron
reviewed
Jun 14, 2022
Contributor
kenotron
left a comment
kenotron
left a comment
There was a problem hiding this comment.
a suggestion / nit to refactor so the writePackageJson is still the same.
kenotron
approved these changes
Jun 14, 2022
7 tasks
1 task
rajsite
added a commit
to ni/nimble
that referenced
this pull request
Jul 28, 2022
# Pull Request ## 🤨 Rationale Updates beachball to the latest version to Fix #625 and partially addresses #601. To fully address #601 we should remove the other locations that have the same workaround as described in the issue. We should let this PR have some runtime after merging to make sure there are no issues before updating other locations. ## 👩💻 Implementation Disconnected the custom `postbump` hook from beachball and will manually verify after merge that lockfile updates happen as expected since beachball >= 2.23.0 from microsoft/beachball#675. ## 🧪 Testing Tweaked the README of the tokens package to trigger the package publishing on the pipeline. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. Doc updates can be done when the package is removed, see details of #601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the package manager is detected to be npm (as determined by presence of
package-lock.json), beachball should runnpm install --package-lock-onlyto updatepackage-lock.jsonafter bumping or syncing.I currently have this new behavior happening automatically rather than under a flag, because arguably it's something beachball should have been doing all along (the only reason it didn't was because the maintainers were primarily using beachball with yarn). If that seems risky, I could add a flag, but if we do that it should definitely become the default behavior in a future major version.
Fixes #525