Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@tracyboehrer
Copy link
Member

@tracyboehrer tracyboehrer commented Feb 6, 2024

#minor

From IcM where the older zh-CN locale was specified in WebChat, and CultureInfo.GetCultures only has the newer (and standard) zh-hans-* and zh-hants-*.

This is for back-compat for existing Composer bots.

@tracyboehrer tracyboehrer added the Automation: Parity with js The PR needs to be ported to JS label Feb 6, 2024
@tracyboehrer tracyboehrer requested a review from a team as a code owner February 6, 2024 15:01
@coveralls
Copy link
Collaborator

coveralls commented Feb 6, 2024

Pull Request Test Coverage Report for Build 384371

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 78.418%

Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Streaming/Payloads/StreamManager.cs 1 90.0%
Totals Coverage Status
Change from base Build 384367: 0.04%
Covered Lines: 26190
Relevant Lines: 33398

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit e5f7ff6 into main Feb 6, 2024
@tracyboehrer tracyboehrer deleted the tracyboehrer/zh-cn-patch branch February 6, 2024 15:40
tracyboehrer added a commit that referenced this pull request Feb 6, 2024
* Manually adding zh-CN and zh-TW to LanguagePolicy

* Only adding zh-cn to LanguagePolicy if missing.

---------

Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: Parity with js The PR needs to be ported to JS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants