Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Throw on decode certificate errors #899

@tracyboehrer

Description

@tracyboehrer

JwtTokenExtractor.validateToken

                    // Note that decodeCertificate will return null if the cert could not
                    // be decoded.  This would likely be the case if it were in an unexpected
                    // encoding.  Going to err on the side of ignoring this check.
                    // May want to reconsider this and throw on null cert.
                    X509Certificate cert = decodeCertificate(key.certificateChain.get(0));
                    if (cert != null && !isCertValid(cert)) {
                        throw new JWTVerificationException("Signing certificate is not valid");
                    }

Metadata

Metadata

Assignees

Labels

Area: AuthenticationThe issue is related to authenticating users (SSO, OAuth, etc.)P0Must Fix. Release-blocker

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions