This repository was archived by the owner on Jan 5, 2026. It is now read-only.
fix: Upgrading restify to fix error on Node version 18+#4515
Merged
tracyboehrer merged 1 commit intomicrosoft:mainfrom Aug 17, 2023
Merged
fix: Upgrading restify to fix error on Node version 18+#4515tracyboehrer merged 1 commit intomicrosoft:mainfrom
tracyboehrer merged 1 commit intomicrosoft:mainfrom
Conversation
Current version leads to the following error on Node 18+:
➜ my-echo-bot npm start
> my-echo-bot@1.0.0 start
> node ./index.js
/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/request.js:848
Request.prototype.closed = function closed() {
^
TypeError: Cannot set property closed of #<Readable> which has only a getter
at patch (/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/request.js:848:30)
at Object.<anonymous> (/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/server.js:33:1)
Pull Request Test Coverage Report for Build 5774405781
💛 - Coveralls |
ceciliaavila
approved these changes
Aug 15, 2023
Collaborator
|
We should update the other templates (empty and core) and the TS versions as well. |
Member
I'll merge this. Can you open an issue to address these other templates? |
tracyboehrer
approved these changes
Aug 17, 2023
Collaborator
Issue created: #4520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#minor
Description
Current version of restify leads to the following error on Node 18+:
Specific Changes
Testing
Create a echo bot dot following the SDK docs, if you are on Node 18 or above you will run into the following error.
Related PR
restify/node-restify#1906