Skip to content

fix: Treat HTTPException as it is, necessary to keep the original status code #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tracyboehrer merged 5 commits into from
Jan 26, 2024
Merged

fix: Treat HTTPException as it is, necessary to keep the original status code #1939

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d48894a
Treat HTTPException as it is, necessary to keep the original status code
takeshi-yashiro May 17, 2022
a7e02b3
Merge branch 'main' into fix-all-http-errors-treated-as-500
axelsrz Oct 27, 2022
f383cd4
Merge branch 'main' into fix-all-http-errors-treated-as-500
tracyboehrer Nov 29, 2023
986ba79
Merge branch 'main' into fix-all-http-errors-treated-as-500
tracyboehrer Jan 25, 2024
61ee1d4
Merge branch 'main' into fix-all-http-errors-treated-as-500
tracyboehrer Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...tbuilder-core/botbuilder/core/integration/aiohttp_channel_service_exception_middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from aiohttp.web import (
middleware,
HTTPException,
HTTPNotImplemented,
HTTPUnauthorized,
HTTPNotFound,
Expand All @@ -27,6 +28,8 @@ async def aiohttp_error_middleware(request, handler):
raise HTTPUnauthorized()
except KeyError:
raise HTTPNotFound()
except HTTPException:
raise
except Exception:
traceback.print_exc()
raise HTTPInternalServerError()