Skip to content

fix: Save a reference to created tasks, to avoid tasks disappearing #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tracyboehrer merged 3 commits into from
Jan 26, 2024
Merged

fix: Save a reference to created tasks, to avoid tasks disappearing #2005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff29eb2
save a reference to created tasks, to avoid tasks disappearing mid-ex…
anio Jun 28, 2023
0674425
Merge branch 'main' into main
tracyboehrer Nov 2, 2023
48e0fe5
Merge branch 'main' into main
tracyboehrer Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...uilder-integration-aiohttp/botbuilder/integration/aiohttp/streaming/aiohttp_web_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def __init__(

def dispose(self):
if self._session:
asyncio.create_task(self._session.close())
task = asyncio.create_task(self._session.close())

async def close(self, close_status: WebSocketCloseStatus, status_description: str):
await self._aiohttp_ws.close(
Expand Down
2 changes: 1 addition & 1 deletion libraries/botframework-streaming/botframework/streaming/protocol_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ async def _on_receive_response(self, identifier: UUID, response: ReceiveResponse

def _on_cancel_stream(self, content_stream_assembler: PayloadStreamAssembler):
# TODO: on original C# code content_stream_assembler is typed as IAssembler
asyncio.create_task(
task = asyncio.create_task(
self._send_operations.send_cancel_stream(
content_stream_assembler.identifier
)
Expand Down