This repository was archived by the owner on Jan 15, 2025. It is now read-only.
port: GetMeetingInfo, meeting start/end events#1167
Closed
mdrichardson wants to merge 1 commit intomicrosoft:mainfrom
Closed
port: GetMeetingInfo, meeting start/end events#1167mdrichardson wants to merge 1 commit intomicrosoft:mainfrom
mdrichardson wants to merge 1 commit intomicrosoft:mainfrom
Conversation
mdrichardson
added
the
Area: Packages: Teams
Contributor
|
Just heads up if you want to get this into R14, please make sure you cherry pick this change into the 4.14 branch. Let me know if you have any questions. Ciao! |
Contributor
Author
|
Closing in favor of #1173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: CI tests fail because it relies on unpublished packages.
Addresses .NET: #1138
Addresses .NET: #1139
#minor (have to include since this doesn't fully fix an issue)
Purpose
Add the action,
GetMeetingInfo()Adds the Triggers,
OnTeamsMeetingStart() andOnTeamsMeetingEnd()Tests
I triggered
GetMeetingInfo()to send on Unknown Intent:Meeting start/end events (data is on
activity.value):Feature Plan
This relies on updating to v4.14 of the SDK (which this PR does not do--it's meant to be ready-to-go after that update gets pushed)
I'll start working on the JS versions. Should be ready to review by Wednesday.