port: JS Teams Tests by mdrichardson · Pull Request #1192 · microsoft/botframework-components

mdrichardson · 2021-07-07T16:33:44Z

This is currently a draft. I'll convert to full PR after the next JS and Components release for the sake of package management.

#minor

Purpose

Add JS Teams package tests
Have .NET and JS share the same .dialog test files

Changes

Move .NET tests from tests/unit/packages/Microsoft.Bot.Components.Teams.Tests to tests\unit\packages\Teams\dotnet to follow the same directory pattern under packages\
Move .dialog test files to ``tests\unit\packages\Teams\Shared Tests`
Add JS tests to tests\unit\packages\Teams\js
Add JS tests to yarn workspaces
Update JS Teams Auth classes to support CloudAdapter
Update JS Teams SendMessageToTeamsChannel to support CloudAdapter. port of this PR

Feature Plan

JS SDK GA Release
Next Components Release

* Add Teams package unit tests (#1171) * fix: Stevenic/ac fix (#1164) * Fixed typo in schema for UpdateActivity * Forgot to copy activityId to outgoing activity in UpdateAdaptiveCard Co-authored-by: Ryan Lengel Isgrig <43043272+ryanlengel@users.noreply.github.com> Co-authored-by: Steven Ickman <stevenic@microsoft.com>

* Update package.json on adaptive + empty * Update more package depdendency * Update template package.jsons * Update yarn.lock * Update old school csharp skills * Update Teams, AdaptiveCards package and misc projs * Update SendMessageToTeamsChannelAsync to work with CloudAdapter (#1170) * chore: Cherry pick 1171 and 1164 into 4.14 (#1172) * Add Teams package unit tests (#1171) * fix: Stevenic/ac fix (#1164) * Fixed typo in schema for UpdateActivity * Forgot to copy activityId to outgoing activity in UpdateAdaptiveCard Co-authored-by: Ryan Lengel Isgrig <43043272+ryanlengel@users.noreply.github.com> Co-authored-by: Steven Ickman <stevenic@microsoft.com> Co-authored-by: Thomas Chung <thchung@microsoft.com> Co-authored-by: Eric Dahlvang <erdahlva@microsoft.com> Co-authored-by: Ryan Lengel Isgrig <43043272+ryanlengel@users.noreply.github.com> Co-authored-by: Steven Ickman <stevenic@microsoft.com> > Looks good. Let's document all of the processes to upgrade versions for all types of components in the repo so that others can do the same. > i.e. > Generators > > 1. generator-bot-adaptive/package.json - bump version > 2. generator-bot-_/packagejson (the rest) - bump version and dependencies:@microsoft/generator-bot-_ versions > > Csproj packages > > 1. Bump version of Microsoft.Bot.Builder.* dependencies > > Nuspec packages > > 1. Bump version of Mocrosoft.Bot.Builder.* dependencies > Npm packages > 2. Bump versions of botbuilder dependencies Good idea. As we figure this out we should just write down the steps.

* Enable SendMessageToTeamsChannel with either BotFrameworkAdapter or CloudAdapter * Get appId from claims * Throw if adapter is not a known type to support SendMessageToTeamsChannel

* Update graph package version * Update graph * Update Teams package * Update teams JS package * Update adaptive cards * HelpAndCancel * Update helpandcancel + welcome dependencies * Change to minor version update * Update to correct JS preview platform.js

Co-authored-by: Thomas Chung <thchung@microsoft.com>

* Fix nuget versioning steps * Fix Teams test reference * Fix Microsoft.Bot.Builder.Dialogs.Adaptive.Testing Co-authored-by: Thomas Chung <thchung@microsoft.com>

tests/unit/packages/Teams/js/package.json

* initial changes * Update templates to use preview Co-authored-by: Thomas Chung <thchung@microsoft.com>

* pull netcore install steps to build-test and package separately * remove netcore step from signing as it is used in packaging

packages/Teams/js/src/actions/actionHelpers.ts

joshgummersall · 2021-07-07T22:56:17Z

packages/Teams/js/src/actions/baseAuthResponseDialog.ts

+    connectionName: string
  ): Promise<Partial<Activity>> {
-    // TODO: Switch to using Cloud OAuth after this PR gets merged: https://github.com/microsoft/botbuilder-js/pull/3149
+    const userTokenClient = dc.context.turnState.get<UserTokenClient>(


You may be able to use https://github.com/microsoft/botbuilder-js/blob/main/libraries/botbuilder-dialogs/src/prompts/userTokenAccess.ts directly now for some of this.

Unfortunately not exported outside of /prompts https://github.com/microsoft/botbuilder-js/blob/main/libraries/botbuilder-dialogs/src/prompts/index.ts

tests/unit/packages/Teams/js/tests/utils.ts

tests/unit/packages/Teams/js/tests/actionTests.test.ts

thomas-chung · 2021-07-08T06:04:11Z

...erators/app/templates/dialogs/BotTourDialog/language-generation/en-us/BotTourDialog.en-us.lg

         ]
      }
   ],
-   "selectAction":{


Is this right? These got nothing to do with your tests right?

Correct. I switched the PR to merge against 4.14 after forgetting that I had built against main. I'll re-submit the PR after cherry-picking the commits over.

mdrichardson · 2021-07-08T16:06:36Z

Closing in favor of this PR, so it can merge against 4.14

Thomas Chung and others added 16 commits June 28, 2021 13:51

Bumping DotNet version

49893b6

Update js sdk to 4.14rc0 as well

b655f26

update tests

0a8cceb

Update JS tests

20b0fdf

Update JS test expectation

e37c9a3

fix: Send message to teams channel support both adapters (#1174)

d6627ba

* Enable SendMessageToTeamsChannel with either BotFrameworkAdapter or CloudAdapter * Get appId from claims * Throw if adapter is not a known type to support SendMessageToTeamsChannel

Update generator package version (#1183)

5f8ad91

Update .NET SDK to 4.14 final (#1187)

307d89c

move .NET tests

5daab7e

Allow previews to generate version as well (#1189)

18217cb

Co-authored-by: Thomas Chung <thchung@microsoft.com>

update for CloudAdapter

f08a504

add js test workspace

00f1dce

update packages

8e9da37

pr-triage bot added the PR: draft label Jul 7, 2021

github-actions bot added the Area: Packages: Teams Relating to the Teams bot component package. label Jul 7, 2021

thomas-chung and others added 3 commits July 7, 2021 09:35

fix: nuget package version override to allow "preview" ring (#1191)

b6fa120

* Fix nuget versioning steps * Fix Teams test reference * Fix Microsoft.Bot.Builder.Dialogs.Adaptive.Testing Co-authored-by: Thomas Chung <thchung@microsoft.com>

un-ignore tests/unit/packages dir

570ebf3

lint

f80c674

mdrichardson commented Jul 7, 2021

View reviewed changes

tests/unit/packages/Teams/js/package.json Show resolved Hide resolved

mdrichardson and others added 4 commits July 7, 2021 11:20

fix: Send message to teams channel support both adapters

08c4011

feat: Use preview version for RC/preview releases (#1194)

02cd57c

* initial changes * Update templates to use preview Co-authored-by: Thomas Chung <thchung@microsoft.com>

package update

4bdd0a7

chore: fix netcore install steps for various deployment stages (#1196)

0a7f14a

* pull netcore install steps to build-test and package separately * remove netcore step from signing as it is used in packaging

joshgummersall reviewed Jul 7, 2021

View reviewed changes

mdrichardson added 2 commits July 7, 2021 21:16

pr review adjustments

52e3355

lint fix

9afcb7f

mdrichardson marked this pull request as ready for review July 8, 2021 04:24

auto-assign bot assigned mdrichardson Jul 8, 2021

pr-triage bot added the PR: unreviewed label Jul 8, 2021

mdrichardson changed the base branch from main to 4.14 July 8, 2021 04:25

Merge branch '4.14' into teamsTests

266cd63

thomas-chung suggested changes Jul 8, 2021

View reviewed changes

pr-triage bot added the PR: reviewed-changes-requested label Jul 8, 2021

mdrichardson changed the base branch from 4.14 to main July 8, 2021 15:32

mdrichardson mentioned this pull request Jul 8, 2021

port: JS Teams Tests and CloudAdapter support #1200

Merged

mdrichardson closed this Jul 8, 2021

tracyboehrer deleted the teamsTests branch July 14, 2022 16:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

port: JS Teams Tests#1192

port: JS Teams Tests#1192
mdrichardson wants to merge 26 commits intomainfrom
teamsTests

mdrichardson commented Jul 7, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

joshgummersall Jul 7, 2021

Uh oh!

mdrichardson Jul 8, 2021

Uh oh!

Uh oh!

Uh oh!

thomas-chung Jul 8, 2021

Uh oh!

mdrichardson Jul 8, 2021

Uh oh!

mdrichardson commented Jul 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mdrichardson commented Jul 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Changes

Feature Plan

Uh oh!

Uh oh!

Uh oh!

joshgummersall Jul 7, 2021

Choose a reason for hiding this comment

Uh oh!

mdrichardson Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thomas-chung Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

mdrichardson Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

mdrichardson commented Jul 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mdrichardson commented Jul 7, 2021 •

edited

Loading