Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

fix: typo in OnMEBotMessagePreviewSend #1212

Merged
mdrichardson merged 4 commits into from
Jul 12, 2021
Merged

fix: typo in OnMEBotMessagePreviewSend #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49281ce
fix typo
mdrichardson Jul 9, 2021
05bb768
delete duplicate, unused .csproj
mdrichardson Jul 9, 2021
6e336a8
add tests
mdrichardson Jul 9, 2021
dc3ef21
remove unused/dupe onTeamsMEConfigurationSetting
mdrichardson Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/Teams/js/src/adaptiveTeamsBotComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import {
OnTeamsMECardButtonClicked,
OnTeamsMEConfigQuerySettingUrl,
OnTeamsMEConfigSetting,
OnTeamsMEConfigurationSetting,
OnTeamsMEFetchTask,
OnTeamsMEQuery,
OnTeamsMESelectItem,
Expand Down Expand Up @@ -185,10 +184,6 @@ export class AdaptiveTeamsBotComponent extends BotComponent {
{ kind: OnTeamsMEFetchTask.$kind, type: OnTeamsMEFetchTask },
{ kind: OnTeamsMEQuery.$kind, type: OnTeamsMEQuery },
{ kind: OnTeamsMESelectItem.$kind, type: OnTeamsMESelectItem },
{
kind: OnTeamsMEConfigurationSetting.$kind,
type: OnTeamsMEConfigurationSetting,
},
{
kind: OnTeamsMESubmitAction.$kind,
type: OnTeamsMESubmitAction,
Expand Down
2 changes: 1 addition & 1 deletion packages/Teams/js/src/conditions/onTeamsMEBotMessagePreviewSend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { OnInvokeActivity } from 'botbuilder-dialogs-adaptive';
* and activity.value.botMessagePreviewAction == 'send'.
*/
export class OnTeamsMEBotMessagePreviewSend extends OnInvokeActivity {
static $kind = 'Teams.OnMEBotMessagePreviewEdit';
static $kind = 'Teams.OnMEBotMessagePreviewSend';

public commandId?: string;

Expand Down
28 changes: 0 additions & 28 deletions packages/Teams/js/src/conditions/onTeamsMEConfigurationSetting.ts
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions ...packages/Microsoft.Bot.Components.Teams.Tests/Microsoft.Bot.Components.Teams.Tests.csproj
View file
Open in desktop

This file was deleted.

50 changes: 50 additions & 0 deletions ...es/Teams/Shared Tests/ConditionalTests/ConditionalsTests_OnTeamsActivityTypes.test.dialog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,26 @@
}
]
},
{
"$kind": "Teams.OnMEBotMessagePreviewEdit",
"condition": "turn.activity.text == 'OnMEBotMessagePreviewEdit'",
"actions": [
{
"$kind": "Microsoft.SendActivity",
"activity": "OnMEBotMessagePreviewEdit"
}
]
},
{
"$kind": "Teams.OnMEBotMessagePreviewSend",
"condition": "turn.activity.text == 'OnMEBotMessagePreviewSend'",
"actions": [
{
"$kind": "Microsoft.SendActivity",
"activity": "OnMEBotMessagePreviewSend"
}
]
},
{
"$kind": "Teams.OnMECardButtonClicked",
"condition": "turn.activity.text == 'OnCardButtonClicked'",
Expand Down Expand Up @@ -372,6 +392,36 @@
"$kind": "Microsoft.Test.AssertReply",
"text": "OnFileConsent"
},
{
"$kind": "Microsoft.Test.UserActivity",
"activity": {
"type": "invoke",
"text": "OnMEBotMessagePreviewEdit",
"value": {
"botMessagePreviewAction": "edit"
},
"name": "composeExtension/submitAction"
}
},
{
"$kind": "Microsoft.Test.AssertReply",
"text": "OnMEBotMessagePreviewEdit"
},
{
"$kind": "Microsoft.Test.UserActivity",
"activity": {
"type": "invoke",
"text": "OnMEBotMessagePreviewSend",
"value": {
"botMessagePreviewAction": "send"
},
"name": "composeExtension/submitAction"
}
},
{
"$kind": "Microsoft.Test.AssertReply",
"text": "OnMEBotMessagePreviewSend"
},
{
"$kind": "Microsoft.Test.UserActivity",
"activity": {
Expand Down