Skip to content

Update Dockerfile.nginx#269

Merged
alliscode merged 1 commit intomicrosoft:mainfrom
huangyingting:patch-1
Aug 29, 2023
Merged

Update Dockerfile.nginx#269
alliscode merged 1 commit intomicrosoft:mainfrom
huangyingting:patch-1

Conversation

@huangyingting
Copy link
Copy Markdown
Contributor

Description

webapp/Dockerfile.nginx flag needs to have --production=false otherwise react-scripts won't be installed to build the webapp

Contribution Checklist

flag needs to have --production=false otherwise react-scripts won't be installed to build the webapp
@alliscode alliscode added this pull request to the merge queue Aug 29, 2023
Merged via the queue into microsoft:main with commit c47fe32 Aug 29, 2023
@huangyingting huangyingting deleted the patch-1 branch September 18, 2023 00:55
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Description
webapp/Dockerfile.nginx flag needs to have --production=false otherwise
react-scripts won't be installed to build the webapp

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
kb0039 pushed a commit to aaronba/chat-copilot that referenced this pull request Jan 8, 2025
### Description
webapp/Dockerfile.nginx flag needs to have --production=false otherwise
react-scripts won't be installed to build the webapp

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
jdtoombs pushed a commit to jdtoombs/chat-copilot that referenced this pull request Apr 10, 2025
…rypipeline (microsoft#269)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants