BREAKING CHANGE: Update WebApi routes for security and RESTful best practices#417
Merged
glahaye merged 11 commits intomicrosoft:mainfrom Oct 3, 2023
glahaye:server_routes
Merged
BREAKING CHANGE: Update WebApi routes for security and RESTful best practices#417glahaye merged 11 commits intomicrosoft:mainfrom glahaye:server_routes
glahaye merged 11 commits intomicrosoft:mainfrom
glahaye:server_routes
Conversation
github-actions
Bot
added
webapp
glahaye
added
PR: breaking change
github-actions
Bot
added
webapp
dehoward
suggested changes
Oct 2, 2023
crickman
previously approved these changes
Oct 2, 2023
Contributor
crickman
left a comment
crickman
left a comment
There was a problem hiding this comment.
Checked areas for which I am familiar (memory stuff)...looks good.,
alliscode
reviewed
Oct 2, 2023
gitri-ms
reviewed
Oct 2, 2023
Co-authored-by: Desmond Howard <dehoward@microsoft.com>
Co-authored-by: Desmond Howard <dehoward@microsoft.com>
Co-authored-by: Desmond Howard <dehoward@microsoft.com>
Co-authored-by: Desmond Howard <dehoward@microsoft.com>
alliscode
approved these changes
Oct 3, 2023
glahaye
changed the title
dehoward
approved these changes
Oct 3, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
…ractices (microsoft#417) ### Motivation and Context The REST routes have grown organically and don't represent the best REST practices. Also, user ID is sometimes taken from routes instead of verified tokens. This PR is to address these two points. ### Description - Changed routes - Renamed classes accordingly - Hid chat archive (formally "bot") schema settings from user - Simplified IContentSafetyService interface and related dependency injection - Removed ConfigureAwait(false) instances (they have no effect in ASP.Net Core apps) - Moved isContentSafetyEnabled to ServiceOptions ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Desmond Howard <dehoward@microsoft.com>
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
…ractices (microsoft#417) ### Motivation and Context The REST routes have grown organically and don't represent the best REST practices. Also, user ID is sometimes taken from routes instead of verified tokens. This PR is to address these two points. ### Description - Changed routes - Renamed classes accordingly - Hid chat archive (formally "bot") schema settings from user - Simplified IContentSafetyService interface and related dependency injection - Removed ConfigureAwait(false) instances (they have no effect in ASP.Net Core apps) - Moved isContentSafetyEnabled to ServiceOptions ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Desmond Howard <dehoward@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The REST routes have grown organically and don't represent the best REST practices.
Also, user ID is sometimes taken from routes instead of verified tokens.
This PR is to address these two points.
Description
Contribution Checklist