fix(copilot): add Windows platform guard to _fix_pipe_blocking_mode()#26
Merged
jrob5756 merged 2 commits intomicrosoft:mainfrom Mar 9, 2026
Merged
Conversation
_fix_pipe_blocking_mode() unconditionally imports fcntl, a Unix-only module, causing ModuleNotFoundError on Windows. O_NONBLOCK does not exist on Windows and pipes are always blocking, so the method is a no-op on that platform. Add sys.platform == 'win32' early return before the fcntl import. Adds 2 tests: - test_skips_on_windows: verifies no-op on win32 - test_runs_on_unix: verifies the method proceeds past the guard Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jrob5756
approved these changes
Mar 7, 2026
jrob5756
requested changes
Mar 7, 2026
Collaborator
jrob5756
left a comment
There was a problem hiding this comment.
I was about to merge then saw the lint issues. Can you take a look at those and we can merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_fix_pipe_blocking_mode() (introduced in #23) unconditionally imports cntl, a Unix-only module, causing ModuleNotFoundError: No module named 'fcntl' on Windows. O_NONBLOCK does not exist on Windows and pipes are always blocking, so the entire method is a no-op on that platform.
Fix
Add sys.platform == "win32" early return before the cntl import.
Validation
Cross-validated with GPT-5.4 (independent model review):
Tests
All 35 copilot provider tests pass.