Skip to content

fix(gates): race web task unconditionally when web dashboard exists #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrob5756 merged 1 commit into from
Apr 20, 2026
Merged

fix(gates): race web task unconditionally when web dashboard exists #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/conductor/engine/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,11 +746,16 @@ async def _handle_gate_with_web(
Returns:
GateResult from whichever input source responded first.
"""
# If no web dashboard or no connections, use CLI only
if self._web_dashboard is None or not self._web_dashboard.has_connections():
# If no web dashboard at all, use CLI only.
if self._web_dashboard is None:
return await self.gate_handler.handle_gate(agent, agent_context)

# Race CLI vs web input
# Race CLI vs web input. We start the web task unconditionally (not only
# when a client is currently connected), because the human often opens
# the per-run dashboard AFTER seeing the gate-waiting notification.
# If we bail early when ``has_connections()`` is False, a later click
# in the dashboard pushes a message to ``_gate_response_queue`` that
# nobody is awaiting, and the workflow hangs forever.
cli_task = asyncio.create_task(
self.gate_handler.handle_gate(agent, agent_context),
name="gate_cli",
Expand Down
Loading