Skip to content

[HttpClient][Curl] Use poll api to avoid select 1024 FD hard limit #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomsonTan merged 2 commits into from
Apr 23, 2026
Merged

[HttpClient][Curl] Use poll api to avoid select 1024 FD hard limit #1426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0836847
[HttpClient][Curl] Use poll api to avoid select 1024 FD hard limit
lucianopa-msft Apr 16, 2026
a83f329
Address PR comments
lucianopa-msft Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 7 additions & 22 deletions lib/http/HttpClient_Curl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <future>
#include <atomic>

#include <poll.h>
#include <curl/curl.h>

#include <unistd.h>
Expand Down Expand Up @@ -462,28 +463,12 @@ class CurlHttpOperation {
*/
static int WaitOnSocket(curl_socket_t sockfd, int for_recv, long timeout_ms)
{
struct timeval tv;
fd_set infd, outfd, errfd;
int res;

tv.tv_sec = timeout_ms / 1000;
tv.tv_usec = (timeout_ms % 1000) * 1000;

FD_ZERO(&infd);
FD_ZERO(&outfd);
FD_ZERO(&errfd);

FD_SET(sockfd, &errfd); /* always check for error */

if(for_recv) {
FD_SET(sockfd, &infd);
} else {
FD_SET(sockfd, &outfd);
}

/* select() returns the number of signalled sockets or -1 */
res = select((int)sockfd + 1, &infd, &outfd, &errfd, &tv);
return res;
struct pollfd pfd;
pfd.fd = sockfd;
pfd.events = for_recv ? POLLIN : POLLOUT;
// Cap timeout to max int value to avoid overflow in poll()
auto timeout = std::min(timeout_ms, static_cast<long>(std::numeric_limits<int>::max()));
return poll(&pfd, 1, static_cast<int>(timeout));
}

// Raw response buffer
Expand Down
Loading