Skip to content

Disable cert revocation check if cert validation is disabled#687

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
ZekeSnider:certificate-revocation-client-config
Aug 1, 2018
Merged

Disable cert revocation check if cert validation is disabled#687
BillyONeal merged 2 commits intomicrosoft:masterfrom
ZekeSnider:certificate-revocation-client-config

Conversation

@ZekeSnider
Copy link
Copy Markdown
Contributor

This addresses an issue described in #664. It makes it so that certificate revocation is not checked if certificate validation is disabled on http_client_config. Previously there was no way to disable this functionality.

@kobykahane
Copy link
Copy Markdown

@ZekeSnider In my opinion, a complete solution to issue #664 would also allow disabling certificate revocation checking without completely disabling certificate validation as well.

@BillyONeal BillyONeal self-assigned this Aug 1, 2018
@BillyONeal BillyONeal force-pushed the certificate-revocation-client-config branch from 9743f2b to 074590c Compare August 1, 2018 21:03
@msftclas
Copy link
Copy Markdown

msftclas commented Aug 1, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ ZekeSnider sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants