Skip to content

Update CMakeLists.txt to install the cmake bindings in the right location#737

Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom
LocutusOfBorg:patch-4
Aug 3, 2018
Merged

Update CMakeLists.txt to install the cmake bindings in the right location#737
ras0219-msft merged 3 commits intomicrosoft:masterfrom
LocutusOfBorg:patch-4

Conversation

@LocutusOfBorg
Copy link
Copy Markdown
Contributor

Update CMakeLists.txt to install the cmake bindings in the right location
/usr/lib/cpprestsdk is not the correct FHS standard cmake location.
It should be placed in /usr/lib/cmake/cpprestsdk instead.

@msftclas
Copy link
Copy Markdown

msftclas commented Apr 23, 2018

CLA assistant check
All CLA requirements met.

…tion

/usr/lib/cpprestsdk is not the correct FHS standard cmake location.
It should be placed in /usr/lib/<triplet>/cmake/cpprestsdk instead.

Same goes for libraries, support multiarch location if we use UNIX
@ras0219-msft
Copy link
Copy Markdown
Contributor

Thanks for the PR and sorry for the long delay!

I agree that we should use GNUInstallDirs to enable configuration of the cpprestsdk bin/lib output directories, however we already have a way to configure the cmake config file output location. Therefore, I suggest using that instead to achieve your desired target:

cmake .. -DCPPREST_EXPORT_DIR=lib/cmake/cpprestsdk

@ras0219-msft ras0219-msft merged commit ecabd2b into microsoft:master Aug 3, 2018
@LocutusOfBorg LocutusOfBorg deleted the patch-4 branch August 18, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants