#436 Building iOS doesn’t seem to work#776
Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom Aug 3, 2018
Merged
Conversation
This moves iOS.cmake into the file so there is on need to add it. Also allows for boost to be static libs versus framework
This was referenced Jun 6, 2018
|
Tried this today and working great. Thanks @mobileben |
Contributor
|
Thanks for the PR @mobileben and sorry for taking so long to address it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous PR #439 had a conflict.
This is updated to work with issues related to Xcode 9. This should also address
#436
#773 (note another PR addresses this too)
#770
Sample cmake to set deployment is
cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_XCODE_ATTRIBUTE_IPHONEOS_DEPLOYMENT_TARGET=9.3 ..
I also remove -fvisibility-inlines-hidden as Xcode defaults it to OFF.
iOS.cmake is now part of this. The recommended toolchain has not been modified in a while. I forked it here.
https://github.com/mobileben/ios-cmake
And this also allows usage of static boost or framework boost.