Skip to content

Conversation

@ChrisGuzak
Copy link
Member

these disable an important diagnostic and have not been needed for a long time as the Xaml Compiler was fixed a few years ago.

@sylveon
Copy link
Contributor

sylveon commented Nov 29, 2021

Why not remove the WINRT_NO_MAKE_DETECTION functionality entirely?

@kennykerr
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kennykerr
Copy link
Collaborator

@sylveon I would be in favor of that, although it can happen as a separate PR.

@jlaanstra
Copy link
Contributor

Why not remove the WINRT_NO_MAKE_DETECTION functionality entirely?

That would be a breaking change.

@sylveon
Copy link
Contributor

sylveon commented Nov 30, 2021

Yes, but code that compiles only using this feature is already wrong and needs to be fixed.

Maybe this is something that could be removed for a potential C++/WinRT 3.0, then.

@kennykerr kennykerr merged commit c28713d into microsoft:master Nov 30, 2021
@kennykerr
Copy link
Collaborator

There's unlikely to be a v3 - more likely that we just slowly evolve, ditching dead features, adding new features, relying on package versioning to allow consumers to handle any breaking changes at their own pace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants