Make winrt::event clearable #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oldnewthing
reviewed
Dec 8, 2021
kennykerr
reviewed
Dec 8, 2021
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kennykerr
changed the title
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While migrating a bunch of C++/CX, I encountered a (rather mediocre) custom
Event<>implementation. After migrating its usage towinrt::event, I noticed there was two major differences between them:Event<>can be copied, and it didn't seem complex to allow copyingwinrt::event.Disposefrom C#) would clear the list of event handlers right away. In C++/WinRT, while manually implementingIClosable, you cannot achieve the same: the memory associated with the event handlers (and any of their captures) is only released upon the reference count reaching 0.So, I implemented and tested both features to achieve parity