Skip to content

Set -pch correctly from targets when not using PCH #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kennykerr merged 2 commits into from
Jan 12, 2022
Merged

Set -pch correctly from targets when not using PCH #1093

kennykerr merged 2 commits into from
Jan 12, 2022

Conversation

@davidmatson
Copy link
Contributor

@davidmatson davidmatson commented Jan 12, 2022 •
edited by kennykerr
Loading

Fixes #1072

@kennykerr kennykerr requested a review from jlaanstra January 12, 2022 20:24
@kennykerr
Copy link
Collaborator

kennykerr commented Jan 12, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 12, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@kennykerr kennykerr changed the title Set -pch correctly from targets when not using PCH (fixes #1072). Set -pch correctly from targets when not using PCH Jan 12, 2022
@kennykerr kennykerr merged commit 4b1e4de into microsoft:master Jan 12, 2022
@davidmatson davidmatson deleted the fixTargetsUsePch branch January 12, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scottj1s Scottj1s Scottj1s approved these changes

@jlaanstra jlaanstra Awaiting requested review from jlaanstra

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NuGet package: CppWinRTPrecompiledHeader should be "." when not using PCH

3 participants

@davidmatson @kennykerr @Scottj1s