Skip to content

Remove workaround for Visual C++ code gen bug #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennykerr merged 2 commits into from
Mar 11, 2022
Merged

Remove workaround for Visual C++ code gen bug #1118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec64a98
remove workaround
kennykerr Mar 10, 2022
8eb0525
Merge branch 'master' into lambda-workaround
kennykerr Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions cppwinrt/code_writers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,17 +1197,9 @@ namespace cppwinrt
method_signature signature{ method };
auto async_types_guard = w.push_async_types(signature.is_async());

//
// Note: this use of a lambda is a workaround for a Visual C++ compiler bug:
// https://developercommunity.visualstudio.com/content/problem/554130/incorrect-code-gen-when-invoking-a-conversion-oper.html
// Once fixed, revert the function body back to this:
//
// return static_cast<% const&>(*this).%(%);
//

std::string_view format = R"( inline auto %::%(%) const%
{
return [&](% const& winrt_impl_base) { return winrt_impl_base.%(%); }(*this);
return static_cast<% const&>(*this).%(%);
}
)";

Expand Down