fix regression in nested visualizations with VS2019+ #1126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
fixes #1121 |
Collaborator
|
The build failures seem to have started with the previous commit: https://github.com/microsoft/cppwinrt/runs/5652229311 |
Member
Author
but intermittently - only 1 of 3 runs has failed. something may have changed with catch and its assumptions of CRT compat. will investigate. out of disk space (sigh... PCH files). |
Collaborator
Need modules. 😋 |
Member
Author
|
Looks like catch occasionally fails with the v143 toolset - backing off for now: #1127 |
kennykerr
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per advice from the VSSDK team, made sure GetChildren returns requested items, not just relying on GetItems. (this lazy technique worked for VS2017, but does not with VS2019+)